PlzNavigate: make ctrl+click works.

content/renderer/render_frame_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_frame_impl.h"
 
 #include <map>
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 5068 matching lines @@
     if (pending_navigation_params_) {
       pending_navigation_params_->common_params.navigation_start =
           base::TimeTicks::Now();
     }
   }
 
   // PlzNavigate: if the navigation is not synchronous, send it to the browser.
   // This includes navigations with no request being sent to the network stack.
   if (IsBrowserSideNavigationEnabled() &&
       info.urlRequest.checkForBrowserSideNavigation() &&
-      ShouldMakeNetworkRequestForURL(url)) {
+      ShouldMakeNetworkRequestForURL(url) &&
+      info.defaultPolicy == blink::WebNavigationPolicyCurrentTab) {

[clamy, 2016/09/09 15:28:01]

I think we should still have a special case for PlzNavigate all the time, but
set up like this:
if (IsBrowserSideNavigationEnabled() &&
    info.urlRequest.checkForBrowserSideNavigation()) {
  if (info.defaultPolicy == blink::WebNavigationPolicyCurrentTab) {
    BeginNavigation(info);
    return blink::WebNavigationPolicyHandledByClient;
  } else {
    loadURLExternally(...);
    return either WebNavigationPolicyHandledByClient or
WebNavigationPolicyIgnore
  }
}

     BeginNavigation(info);
     return blink::WebNavigationPolicyHandledByClient;
   }
 
   return info.defaultPolicy;
 }
 
 void RenderFrameImpl::OnGetSavableResourceLinks() {
   std::vector<GURL> resources_list;
   std::vector<SavableSubframe> subframes;
@@ skipping 1240 matching lines @@
   // event target. Potentially a Pepper plugin will receive the event.
   // In order to tell whether a plugin gets the last mouse event and which it
   // is, we set |pepper_last_mouse_event_target_| to null here. If a plugin gets
   // the event, it will notify us via DidReceiveMouseEvent() and set itself as
   // |pepper_last_mouse_event_target_|.
   pepper_last_mouse_event_target_ = nullptr;
 #endif
 }
 
 }  // namespace content