Generate INVALID_OPERATION error when attempting to bind a deleted object

Generate INVALID_OPERATION error when attempting to bind a deleted object

According to the new spec, a INVALID_OPERATION error should be generated
when attemping to call bind* function on a delete object and the origin
binding should be keeped, including buffers, textures, renderbuffers and
framebuffers.

BUG=chromium:644957
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/ef7630800e91abbb104e76515b92e682e189ca1e
Cr-Commit-Position: refs/heads/master@{#417875}

[Jiawei, 2016-09-08 08:47:01]

Description was changed from

==========
Generate INVALID_OPERATION error when attempting to bind a deleted object

According to the new spec, a INVALID_OPERATION error should be generated
when attemping to call bind* function on a delete object and the origin
binding should be keeped, including buffers, textures, renderbuffers and
framebuffers.

BUG=chromium:644957
==========

to

==========
Generate INVALID_OPERATION error when attempting to bind a deleted object

According to the new spec, a INVALID_OPERATION error should be generated
when attemping to call bind* function on a delete object and the origin
binding should be keeped, including buffers, textures, renderbuffers and
framebuffers.

BUG=chromium:644957
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[Jiawei, 2016-09-08 08:49:59]

jiawei.shao@intel.com changed reviewers:
+ qiankun.miao@intel.com

[qiankun, 2016-09-08 08:59:04]

qiankun.miao@intel.com changed reviewers:
+ kbr@chromium.org, yunchao.he@intel.com, zmo@chromium.org

[qiankun, 2016-09-08 08:59:05]

LGTM.
others: PTAL

[qiankun, 2016-09-08 08:59:06]

LGTM.
others: PTAL

[qiankun, 2016-09-08 09:01:00]

https://codereview.chromium.org/2322943002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
(right):

https://codereview.chromium.org/2322943002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:1552:
synthesizeGLError(GL_INVALID_OPERATION, "bindBuffer", "attempt to bind a deleted
renderbuffer");
typo: bindBuffer -> bindRenderbuffer

[Zhenyao Mo, 2016-09-08 15:55:02]

On 2016/09/08 09:01:00, qiankun wrote:
>
https://codereview.chromium.org/2322943002/diff/1/third_party/WebKit/Source/m...
> File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
> (right):
> 
>
https://codereview.chromium.org/2322943002/diff/1/third_party/WebKit/Source/m...
> third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:1552:
> synthesizeGLError(GL_INVALID_OPERATION, "bindBuffer", "attempt to bind a
deleted
> renderbuffer");
> typo: bindBuffer -> bindRenderbuffer

Looks good to me, but please fix the typo qiankun pointed out

[yunchao, 2016-09-08 18:38:05]

Jiawei, the conformance test has been rolled into Chromium project. Please
update the webgl conformance expectations. Then bots will run the conformance
test with updated expectations. Make sure all bots are green.

[Jiawei, 2016-09-09 02:08:14]

The CQ bit was checked by jiawei.shao@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 02:08:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 03:11:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 03:11:17]

Dry run: Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[Jiawei, 2016-09-09 07:10:16]

The CQ bit was checked by jiawei.shao@intel.com

[Jiawei, 2016-09-09 07:10:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
qiankun.miao@intel.com
Link to the patchset: https://codereview.chromium.org/2322943002/#ps80001
(title: "Format cl")

[Jiawei, 2016-09-09 07:10:18]

The CQ bit was unchecked by jiawei.shao@intel.com

[Ken Russell (switch to Gerrit), 2016-09-09 18:50:26]

This LGTM. I think we should land this ASAP to not have the code in an
inconsistent/incorrect state for long periods of time. The conformance
expectations can be updated again.

[Zhenyao Mo, 2016-09-09 18:52:19]

On 2016/09/09 18:50:26, Ken Russell wrote:
> This LGTM. I think we should land this ASAP to not have the code in an
> inconsistent/incorrect state for long periods of time. The conformance
> expectations can be updated again.

lgtm

let's land this now

[Zhenyao Mo, 2016-09-09 18:52:23]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2016-09-09 18:52:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 18:55:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 18:55:36]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ken Russell (switch to Gerrit), 2016-09-09 20:14:36]

On 2016/09/09 18:55:36, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
>   mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Jiawei, please rebase and CQ if you can, otherwise please ask Qiankun to click
the CQ box for you, or we'll get to it ASAP. Thanks.

[Jiawei, 2016-09-12 04:27:45]

The CQ bit was checked by jiawei.shao@intel.com

[Jiawei, 2016-09-12 04:27:45]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
zmo@chromium.org, qiankun.miao@intel.com
Link to the patchset: https://codereview.chromium.org/2322943002/#ps100001
(title: "Solve merge conflict")

[commit-bot: I haz the power, 2016-09-12 04:27:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 06:03:49]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-09-12 06:06:31]

Description was changed from

==========
Generate INVALID_OPERATION error when attempting to bind a deleted object

According to the new spec, a INVALID_OPERATION error should be generated
when attemping to call bind* function on a delete object and the origin
binding should be keeped, including buffers, textures, renderbuffers and
framebuffers.

BUG=chromium:644957
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Generate INVALID_OPERATION error when attempting to bind a deleted object

According to the new spec, a INVALID_OPERATION error should be generated
when attemping to call bind* function on a delete object and the origin
binding should be keeped, including buffers, textures, renderbuffers and
framebuffers.

BUG=chromium:644957
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/ef7630800e91abbb104e76515b92e682e189ca1e
Cr-Commit-Position: refs/heads/master@{#417875}
==========

[commit-bot: I haz the power, 2016-09-12 06:06:33]

Patchset 6 (id:??) landed as
https://crrev.com/ef7630800e91abbb104e76515b92e682e189ca1e
Cr-Commit-Position: refs/heads/master@{#417875}