Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2322893002: gpu: Remove unused GpuChildThread::gpu_preferences_. (Closed)

Created:
4 years, 3 months ago by sadrul
Modified:
4 years, 3 months ago
Reviewers:
piman
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Remove unused GpuChildThread::gpu_preferences_. GpuChildThread itself never uses |gpu_preferences_|. However, GpuChannelManager holds a reference to it. So remove it from GpuChildThread, and have GpuChannelManager, which actually uses it, own it instead. BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/3f8d0fabf3859746b38c19a7c36c0ffc73aea6a4 Cr-Commit-Position: refs/heads/master@{#417331}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -24 lines) Patch
M content/gpu/gpu_child_thread.h View 3 chunks +1 line, -6 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 5 chunks +10 lines, -15 lines 0 comments Download
M content/gpu/in_process_gpu_thread.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/ipc/service/gpu_channel_manager.h View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 21 (16 generated)
sadrul
4 years, 3 months ago (2016-09-08 16:47:39 UTC) #14
piman
LGTM, thanks for the cleanup!
4 years, 3 months ago (2016-09-08 16:57:56 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2322893002/20001
4 years, 3 months ago (2016-09-08 17:42:13 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-08 17:48:00 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 17:49:57 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3f8d0fabf3859746b38c19a7c36c0ffc73aea6a4
Cr-Commit-Position: refs/heads/master@{#417331}

Powered by Google App Engine
This is Rietveld 408576698