Propagate connection info to Blimp android UI.

Propagate connection info to Blimp android UI.

In 0.5 client, it's done in BlimpClientSession, which broadcasts
connection events, assignment result to the Java layer.

1. This CL port these functionalities to native code, in
core/session/connection_status. ConnectionStatus will cache engine info
and broadcast network events to other components in Blimp.

2. Also use delegate pattern to decouple the settings JNI bridge and
BlimpClientContextImpl.

3. Some utilities functions prepared for error messages handling in UI.

BUG=624451, 646655
Committed: https://crrev.com/d5f7fda40e4827bd9d9114acef9b126893b59892
Cr-Commit-Position: refs/heads/master@{#418707}

[xingliu, 2016-09-08 01:34:52]

Description was changed from

==========
Propagate connection info to Blimp android UI.

In 0.5 client, it's done in BlimpClientSession.java, which broadcasts
connection events, assignment result to the Java layer.

This CL port these functionalities to native code, in
core/session/connection_status. ConnectionStatus will cache engine info
and broadcast network events to other components in Blimp.

Also use delegate pattern to decouple the settings JNI bridge and
BlimpClientContextImpl.

BUG=624451
==========

to

==========
Propagate connection info to Blimp android UI.

In 0.5 client, it's done in BlimpClientSession.java, which broadcasts
connection events, assignment result to the Java layer.

1. This CL port these functionalities to native code, in
core/session/connection_status. ConnectionStatus will cache engine info
and broadcast network events to other components in Blimp.

2. Also use delegate pattern to decouple the settings JNI bridge and
BlimpClientContextImpl.

3. Some utilities functions prepared for error messages handling in UI.

BUG=624451
==========

[xingliu, 2016-09-08 02:08:03]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 02:08:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xingliu, 2016-09-08 02:09:14]

xingliu@chromium.org changed reviewers:
+ dtrainor@chromium.org, nyquist@chromium.org

[xingliu, 2016-09-08 02:09:15]

Propagating network events and connection info in native layer and Java layer.

[commit-bot: I haz the power, 2016-09-08 02:45:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 02:45:36]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[xingliu, 2016-09-08 16:31:41]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 16:31:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xingliu, 2016-09-08 17:32:55]

Description was changed from

==========
Propagate connection info to Blimp android UI.

In 0.5 client, it's done in BlimpClientSession.java, which broadcasts
connection events, assignment result to the Java layer.

1. This CL port these functionalities to native code, in
core/session/connection_status. ConnectionStatus will cache engine info
and broadcast network events to other components in Blimp.

2. Also use delegate pattern to decouple the settings JNI bridge and
BlimpClientContextImpl.

3. Some utilities functions prepared for error messages handling in UI.

BUG=624451
==========

to

==========
Propagate connection info to Blimp android UI.

In 0.5 client, it's done in BlimpClientSession, which broadcasts
connection events, assignment result to the Java layer.

1. This CL port these functionalities to native code, in
core/session/connection_status. ConnectionStatus will cache engine info
and broadcast network events to other components in Blimp.

2. Also use delegate pattern to decouple the settings JNI bridge and
BlimpClientContextImpl.

3. Some utilities functions prepared for error messages handling in UI.

BUG=624451
==========

[commit-bot: I haz the power, 2016-09-08 17:46:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 17:46:44]

Dry run: This issue passed the CQ dry run.

[xingliu, 2016-09-08 21:41:17]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 21:41:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 23:01:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 23:01:13]

Dry run: This issue passed the CQ dry run.

[David Trainor- moved to gerrit, 2016-09-09 19:33:47]

https://codereview.chromium.org/2322843002/diff/80001/blimp/client/core/andro...
File
blimp/client/core/android/java/src/org/chromium/blimp/core/session/EngineInfo.java
(right):

https://codereview.chromium.org/2322843002/diff/80001/blimp/client/core/andro...
blimp/client/core/android/java/src/org/chromium/blimp/core/session/EngineInfo.java:10:
public class EngineInfo {
Does it make sense to set this data from native and just make this class a
window into the native ConnectionStatus?

Or just cache these two directly in AboutBlimpPreferences

Or get of the variables and hit native directly for the values?

https://codereview.chromium.org/2322843002/diff/80001/blimp/client/core/andro...
File
blimp/client/core/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java
(right):

https://codereview.chromium.org/2322843002/diff/80001/blimp/client/core/andro...
blimp/client/core/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java:277:
private void onConnected(String ip) {
On that same note, should these all be hidden behind a ConnectionStatus class in
Java?

https://codereview.chromium.org/2322843002/diff/80001/blimp/client/core/blimp...
File blimp/client/core/blimp_client_context_impl.cc (right):

https://codereview.chromium.org/2322843002/diff/80001/blimp/client/core/blimp...
blimp/client/core/blimp_client_context_impl.cc:146: void
BlimpClientContextImpl::OnConnected() {
Get rid of these and make ConnectionStatus the NetworkObserver?

https://codereview.chromium.org/2322843002/diff/80001/blimp/client/core/sessi...
File blimp/client/core/session/connection_status.h (right):

https://codereview.chromium.org/2322843002/diff/80001/blimp/client/core/sessi...
blimp/client/core/session/connection_status.h:19: class ConnectionStatus {
Should this be a NetworkEventObserver and BlimpClientContextImpl can not be one.

https://codereview.chromium.org/2322843002/diff/80001/blimp/client/core/sessi...
blimp/client/core/session/connection_status.h:38: void onAssignmentResult(int
result, const Assignment& assignment);
on -> On

[xingliu, 2016-09-10 22:34:10]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-10 22:34:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xingliu, 2016-09-10 22:44:39]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-10 22:44:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xingliu, 2016-09-10 22:45:47]

Clean up the code based on review.
Thanks for the suggestion, the ip cache indeed doesn't make sense.

https://codereview.chromium.org/2322843002/diff/80001/blimp/client/core/andro...
File
blimp/client/core/android/java/src/org/chromium/blimp/core/session/EngineInfo.java
(right):

https://codereview.chromium.org/2322843002/diff/80001/blimp/client/core/andro...
blimp/client/core/android/java/src/org/chromium/blimp/core/session/EngineInfo.java:10:
public class EngineInfo {
On 2016/09/09 19:33:47, David Trainor wrote:
> Does it make sense to set this data from native and just make this class a
> window into the native ConnectionStatus?
> 
> Or just cache these two directly in AboutBlimpPreferences
> 
> Or get of the variables and hit native directly for the values?

Removed, now the ip is not cached anywhere in Java.

https://codereview.chromium.org/2322843002/diff/80001/blimp/client/core/andro...
File
blimp/client/core/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java
(right):

https://codereview.chromium.org/2322843002/diff/80001/blimp/client/core/andro...
blimp/client/core/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java:277:
private void onConnected(String ip) {
On 2016/09/09 19:33:47, David Trainor wrote:
> On that same note, should these all be hidden behind a ConnectionStatus class
in
> Java?

Remove ip cahces.

Also changed the onResume logic so it won't reload every entry but only
necessary ones.

InitNative also get called after Java loads the xml resource.

https://codereview.chromium.org/2322843002/diff/80001/blimp/client/core/blimp...
File blimp/client/core/blimp_client_context_impl.cc (right):

https://codereview.chromium.org/2322843002/diff/80001/blimp/client/core/blimp...
blimp/client/core/blimp_client_context_impl.cc:146: void
BlimpClientContextImpl::OnConnected() {
On 2016/09/09 19:33:47, David Trainor wrote:
> Get rid of these and make ConnectionStatus the NetworkObserver?

Make sense. Done.

https://codereview.chromium.org/2322843002/diff/80001/blimp/client/core/sessi...
File blimp/client/core/session/connection_status.h (right):

https://codereview.chromium.org/2322843002/diff/80001/blimp/client/core/sessi...
blimp/client/core/session/connection_status.h:19: class ConnectionStatus {
On 2016/09/09 19:33:47, David Trainor wrote:
> Should this be a NetworkEventObserver and BlimpClientContextImpl can not be
one.

Done.

https://codereview.chromium.org/2322843002/diff/80001/blimp/client/core/sessi...
blimp/client/core/session/connection_status.h:38: void onAssignmentResult(int
result, const Assignment& assignment);
On 2016/09/09 19:33:47, David Trainor wrote:
> on -> On

Done.

[commit-bot: I haz the power, 2016-09-11 00:11:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-11 00:11:29]

Dry run: This issue passed the CQ dry run.

[David Trainor- moved to gerrit, 2016-09-13 05:54:52]

https://codereview.chromium.org/2322843002/diff/140001/blimp/client/core/sess...
File blimp/client/core/session/connection_status.cc (right):

https://codereview.chromium.org/2322843002/diff/140001/blimp/client/core/sess...
blimp/client/core/session/connection_status.cc:12:
ConnectionStatus::~ConnectionStatus() = default;
new line before this

https://codereview.chromium.org/2322843002/diff/140001/blimp/client/core/sess...
blimp/client/core/session/connection_status.cc:14: const net::IPEndPoint&
ConnectionStatus::GetIpEndPoint() {
inline this in header?  same with is_connected()

https://codereview.chromium.org/2322843002/diff/140001/blimp/client/core/sett...
File blimp/client/core/settings/android/blimp_settings_android.cc (right):

https://codereview.chromium.org/2322843002/diff/140001/blimp/client/core/sett...
blimp/client/core/settings/android/blimp_settings_android.cc:34:
BlimpSettingsAndroid::BlimpSettingsAndroid(JNIEnv* env, jobject jobj) {
delegate_(nullptr)?

https://codereview.chromium.org/2322843002/diff/140001/blimp/client/core/sett...
blimp/client/core/settings/android/blimp_settings_android.cc:47:
delegate_->GetIdentitySource()->RemoveObserver(this);
Put this in the destructor.  Sorry for not catching this earlier.

https://codereview.chromium.org/2322843002/diff/140001/blimp/client/core/sett...
blimp/client/core/settings/android/blimp_settings_android.cc:55: // Set the
Delegate, it can only get called for once.
get -> be.  Remove for.  Put this comment in the header.

https://codereview.chromium.org/2322843002/diff/140001/blimp/client/core/sett...
blimp/client/core/settings/android/blimp_settings_android.cc:100:
Java_AboutBlimpPreferences_onConnected(env, java_obj_, jengine_ip);
If it's not connected can we expose the error reason here?  Maybe make it
engine_identifier instead of engine_ip?  That way an error reason makes (at
least a little) more sense when we sub it in? :)

https://codereview.chromium.org/2322843002/diff/140001/blimp/client/core/sett...
blimp/client/core/settings/android/blimp_settings_android.cc:105:
Java_AboutBlimpPreferences_onDisconnected(env, java_obj_);
Is this the same as onConnected() but with an empty string?  Can we just call
setEngineIp or setEngineIdentifier?

https://codereview.chromium.org/2322843002/diff/140001/blimp/client/public/se...
File blimp/client/public/session/assignment.h (right):

https://codereview.chromium.org/2322843002/diff/140001/blimp/client/public/se...
blimp/client/public/session/assignment.h:12: #include
"net/cert/x509_certificate.h"
why remove forward declare?

[xingliu, 2016-09-13 18:29:34]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 18:30:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xingliu, 2016-09-13 18:36:06]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[xingliu, 2016-09-13 18:36:15]

https://codereview.chromium.org/2322843002/diff/140001/blimp/client/core/sess...
File blimp/client/core/session/connection_status.cc (right):

https://codereview.chromium.org/2322843002/diff/140001/blimp/client/core/sess...
blimp/client/core/session/connection_status.cc:12:
ConnectionStatus::~ConnectionStatus() = default;
On 2016/09/13 05:54:51, David Trainor wrote:
> new line before this

Done.

https://codereview.chromium.org/2322843002/diff/140001/blimp/client/core/sess...
blimp/client/core/session/connection_status.cc:14: const net::IPEndPoint&
ConnectionStatus::GetIpEndPoint() {
On 2016/09/13 05:54:51, David Trainor wrote:
> inline this in header?  same with is_connected()

Done.

https://codereview.chromium.org/2322843002/diff/140001/blimp/client/core/sett...
File blimp/client/core/settings/android/blimp_settings_android.cc (right):

https://codereview.chromium.org/2322843002/diff/140001/blimp/client/core/sett...
blimp/client/core/settings/android/blimp_settings_android.cc:34:
BlimpSettingsAndroid::BlimpSettingsAndroid(JNIEnv* env, jobject jobj) {
On 2016/09/13 05:54:51, David Trainor wrote:
> delegate_(nullptr)?

Done. Did it in the header, but put it here seems to be faster for compiling.

https://codereview.chromium.org/2322843002/diff/140001/blimp/client/core/sett...
blimp/client/core/settings/android/blimp_settings_android.cc:47:
delegate_->GetIdentitySource()->RemoveObserver(this);
On 2016/09/13 05:54:51, David Trainor wrote:
> Put this in the destructor.  Sorry for not catching this earlier.

Done.

https://codereview.chromium.org/2322843002/diff/140001/blimp/client/core/sett...
blimp/client/core/settings/android/blimp_settings_android.cc:55: // Set the
Delegate, it can only get called for once.
On 2016/09/13 05:54:51, David Trainor wrote:
> get -> be.  Remove for.  Put this comment in the header.

Done.

https://codereview.chromium.org/2322843002/diff/140001/blimp/client/core/sett...
blimp/client/core/settings/android/blimp_settings_android.cc:100:
Java_AboutBlimpPreferences_onConnected(env, java_obj_, jengine_ip);
On 2016/09/13 05:54:51, David Trainor wrote:
> If it's not connected can we expose the error reason here?  Maybe make it
> engine_identifier instead of engine_ip?  That way an error reason makes (at
> least a little) more sense when we sub it in? :)

Done, removed Java onConnect, onDisconnect, call UpdateEngineInfo in native
instead. Also align UpdateEngineInfo with OnSignIn OnSignOut, make them private
const. Also put interface implementations into private.

https://codereview.chromium.org/2322843002/diff/140001/blimp/client/core/sett...
blimp/client/core/settings/android/blimp_settings_android.cc:105:
Java_AboutBlimpPreferences_onDisconnected(env, java_obj_);
On 2016/09/13 05:54:51, David Trainor wrote:
> Is this the same as onConnected() but with an empty string?  Can we just call
> setEngineIp or setEngineIdentifier?

Renamed it to UpdateEngineInfo..

https://codereview.chromium.org/2322843002/diff/140001/blimp/client/public/se...
File blimp/client/public/session/assignment.h (right):

https://codereview.chromium.org/2322843002/diff/140001/blimp/client/public/se...
blimp/client/public/session/assignment.h:12: #include
"net/cert/x509_certificate.h"
On 2016/09/13 05:54:51, David Trainor wrote:
> why remove forward declare?

Done.

[commit-bot: I haz the power, 2016-09-13 18:36:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 19:56:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 19:56:59]

Dry run: This issue passed the CQ dry run.

[nyquist, 2016-09-14 00:03:16]

Description was changed from

==========
Propagate connection info to Blimp android UI.

In 0.5 client, it's done in BlimpClientSession, which broadcasts
connection events, assignment result to the Java layer.

1. This CL port these functionalities to native code, in
core/session/connection_status. ConnectionStatus will cache engine info
and broadcast network events to other components in Blimp.

2. Also use delegate pattern to decouple the settings JNI bridge and
BlimpClientContextImpl.

3. Some utilities functions prepared for error messages handling in UI.

BUG=624451
==========

to

==========
Propagate connection info to Blimp android UI.

In 0.5 client, it's done in BlimpClientSession, which broadcasts
connection events, assignment result to the Java layer.

1. This CL port these functionalities to native code, in
core/session/connection_status. ConnectionStatus will cache engine info
and broadcast network events to other components in Blimp.

2. Also use delegate pattern to decouple the settings JNI bridge and
BlimpClientContextImpl.

3. Some utilities functions prepared for error messages handling in UI.

BUG=624451, 646655
==========

[David Trainor- moved to gerrit, 2016-09-14 15:49:02]

lgtm % nits

https://codereview.chromium.org/2322843002/diff/200001/blimp/client/core/andr...
File
blimp/client/core/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java
(right):

https://codereview.chromium.org/2322843002/diff/200001/blimp/client/core/andr...
blimp/client/core/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java:31:
private static final String PREF_ENGINE_INFO = "blimp_engine_ip";
Change the string to info as well?

https://codereview.chromium.org/2322843002/diff/200001/blimp/client/core/sett...
File blimp/client/core/settings/android/blimp_settings_android.cc (right):

https://codereview.chromium.org/2322843002/diff/200001/blimp/client/core/sett...
blimp/client/core/settings/android/blimp_settings_android.cc:93:
delegate_->GetConnectionStatus()->engine_endpoint().address().ToString();
I assume pulling the error message will happen in a follow up patch?

[xingliu, 2016-09-14 19:10:41]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 19:11:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 19:17:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 19:17:21]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xingliu, 2016-09-14 20:33:58]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 20:34:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xingliu, 2016-09-14 20:44:24]

Resolved some merge conflicts and some minor fixes according to review, prepare
to commit.

https://codereview.chromium.org/2322843002/diff/200001/blimp/client/core/andr...
File
blimp/client/core/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java
(right):

https://codereview.chromium.org/2322843002/diff/200001/blimp/client/core/andr...
blimp/client/core/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java:31:
private static final String PREF_ENGINE_INFO = "blimp_engine_ip";
On 2016/09/14 15:49:02, David Trainor wrote:
> Change the string to info as well?

Done, there will be resource migration in next patch, in this patch added an
entry to xml file to make both 0.5 and 0.6 works.

https://codereview.chromium.org/2322843002/diff/200001/blimp/client/core/sett...
File blimp/client/core/settings/android/blimp_settings_android.cc (right):

https://codereview.chromium.org/2322843002/diff/200001/blimp/client/core/sett...
blimp/client/core/settings/android/blimp_settings_android.cc:93:
delegate_->GetConnectionStatus()->engine_endpoint().address().ToString();
On 2016/09/14 15:49:02, David Trainor wrote:
> I assume pulling the error message will happen in a follow up patch?

Yes.

[xingliu, 2016-09-14 21:51:27]

The CQ bit was unchecked by xingliu@chromium.org

[xingliu, 2016-09-14 21:51:30]

The CQ bit was checked by xingliu@chromium.org

[xingliu, 2016-09-14 21:51:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/2322843002/#ps240001
(title: "Merge conflicts.")

[commit-bot: I haz the power, 2016-09-14 21:52:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 22:53:25]

Description was changed from

==========
Propagate connection info to Blimp android UI.

In 0.5 client, it's done in BlimpClientSession, which broadcasts
connection events, assignment result to the Java layer.

1. This CL port these functionalities to native code, in
core/session/connection_status. ConnectionStatus will cache engine info
and broadcast network events to other components in Blimp.

2. Also use delegate pattern to decouple the settings JNI bridge and
BlimpClientContextImpl.

3. Some utilities functions prepared for error messages handling in UI.

BUG=624451, 646655
==========

to

==========
Propagate connection info to Blimp android UI.

In 0.5 client, it's done in BlimpClientSession, which broadcasts
connection events, assignment result to the Java layer.

1. This CL port these functionalities to native code, in
core/session/connection_status. ConnectionStatus will cache engine info
and broadcast network events to other components in Blimp.

2. Also use delegate pattern to decouple the settings JNI bridge and
BlimpClientContextImpl.

3. Some utilities functions prepared for error messages handling in UI.

BUG=624451, 646655
==========

[commit-bot: I haz the power, 2016-09-14 22:53:26]

Committed patchset #13 (id:240001)

[commit-bot: I haz the power, 2016-09-14 22:56:29]

Description was changed from

==========
Propagate connection info to Blimp android UI.

In 0.5 client, it's done in BlimpClientSession, which broadcasts
connection events, assignment result to the Java layer.

1. This CL port these functionalities to native code, in
core/session/connection_status. ConnectionStatus will cache engine info
and broadcast network events to other components in Blimp.

2. Also use delegate pattern to decouple the settings JNI bridge and
BlimpClientContextImpl.

3. Some utilities functions prepared for error messages handling in UI.

BUG=624451, 646655
==========

to

==========
Propagate connection info to Blimp android UI.

In 0.5 client, it's done in BlimpClientSession, which broadcasts
connection events, assignment result to the Java layer.

1. This CL port these functionalities to native code, in
core/session/connection_status. ConnectionStatus will cache engine info
and broadcast network events to other components in Blimp.

2. Also use delegate pattern to decouple the settings JNI bridge and
BlimpClientContextImpl.

3. Some utilities functions prepared for error messages handling in UI.

BUG=624451, 646655

Committed: https://crrev.com/d5f7fda40e4827bd9d9114acef9b126893b59892
Cr-Commit-Position: refs/heads/master@{#418707}
==========

[commit-bot: I haz the power, 2016-09-14 22:56:31]

Patchset 13 (id:??) landed as
https://crrev.com/d5f7fda40e4827bd9d9114acef9b126893b59892
Cr-Commit-Position: refs/heads/master@{#418707}