blimp/client/core/android/java/src/org/chromium/blimp/core/settings/BlimpPreferencesDelegate.java - Issue 2322843002: Propagate connection info to Blimp android UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/android/java/src/org/chromium/blimp/core/settings/BlimpPreferencesDelegate.java

Issue 2322843002: Propagate connection info to Blimp android UI. (Closed)

Patch Set: Merge conflicts. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « blimp/client/core/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java ('k') | blimp/client/core/blimp_client_context_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/core/android/java/src/org/chromium/blimp/core/settings/BlimpPreferencesDelegate.java

diff --git a/blimp/client/core/android/java/src/org/chromium/blimp/core/settings/BlimpPreferencesDelegate.java b/blimp/client/core/android/java/src/org/chromium/blimp/core/settings/BlimpPreferencesDelegate.java

index 4c25c3ac5caa0e589d30d97035c429eb79c9cf7d..d7801094de58ef8a7e31cb8e9885f07afb257057 100644

--- a/blimp/client/core/android/java/src/org/chromium/blimp/core/settings/BlimpPreferencesDelegate.java

+++ b/blimp/client/core/android/java/src/org/chromium/blimp/core/settings/BlimpPreferencesDelegate.java

@@ -17,7 +17,8 @@ public interface BlimpPreferencesDelegate {

/**

* Initialize setting page.

- * Setup all helper objects that the setting page needs, such as IdentitySource in native code.

+ * Set the delegate in native. We don't directly pass the delegate to native

+ * BlimpSettingsAndroid because jni pointer can't be cast to parent class via reinterpret_cast.

void initSettingsPage(AboutBlimpPreferences preferences);