Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Unified Diff: components/offline_pages/downloads/download_ui_adapter.cc

Issue 2322833002: Support serving offline page by offline ID (Closed)
Patch Set: Remove unused variable to fix trybot Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/downloads/download_ui_adapter.cc
diff --git a/components/offline_pages/downloads/download_ui_adapter.cc b/components/offline_pages/downloads/download_ui_adapter.cc
index 1ef3534dba10ccb046ae8e1894f32ae606d9ff24..49fc70e0f80efe45f321d01c602362aac711dce0 100644
--- a/components/offline_pages/downloads/download_ui_adapter.cc
+++ b/components/offline_pages/downloads/download_ui_adapter.cc
@@ -130,14 +130,14 @@ void DownloadUIAdapter::DeleteItem(const std::string& guid) {
weak_ptr_factory_.GetWeakPtr()));
}
-GURL DownloadUIAdapter::GetOfflineUrlByGuid(
+int64_t DownloadUIAdapter::GetOfflineIdByGuid(
const std::string& guid) const {
// TODO(dimich): when requests are also in the cache, filter them out.
- // Requests do not yet have offline URL.
+ // Requests do not yet have offline ID.
DownloadUIItems::const_iterator it = items_.find(guid);
if (it != items_.end())
- return it->second->offline_url;
- return GURL();
+ return it->second->offline_id;
+ return 0;
}
// Note that several LoadCache calls may be issued before the async GetAllPages
« no previous file with comments | « components/offline_pages/downloads/download_ui_adapter.h ('k') | components/offline_pages/offline_page_model_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698