Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: components/offline_pages/downloads/download_ui_adapter.cc

Issue 2322833002: Support serving offline page by offline ID (Closed)
Patch Set: Remove unused variable to fix trybot Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/downloads/download_ui_adapter.h" 5 #include "components/offline_pages/downloads/download_ui_adapter.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/guid.h" 8 #include "base/guid.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 std::vector<int64_t> page_ids; 123 std::vector<int64_t> page_ids;
124 page_ids.push_back(it->second->offline_id); 124 page_ids.push_back(it->second->offline_id);
125 // TODO(dimich): This should be ExpirePages(...Now()..) when Expire is 125 // TODO(dimich): This should be ExpirePages(...Now()..) when Expire is
126 // firing Observer method. The resulting Observer notification will update 126 // firing Observer method. The resulting Observer notification will update
127 // local cache. 127 // local cache.
128 model_->DeletePagesByOfflineId( 128 model_->DeletePagesByOfflineId(
129 page_ids, base::Bind(&DownloadUIAdapter::OnDeletePagesDone, 129 page_ids, base::Bind(&DownloadUIAdapter::OnDeletePagesDone,
130 weak_ptr_factory_.GetWeakPtr())); 130 weak_ptr_factory_.GetWeakPtr()));
131 } 131 }
132 132
133 GURL DownloadUIAdapter::GetOfflineUrlByGuid( 133 int64_t DownloadUIAdapter::GetOfflineIdByGuid(
134 const std::string& guid) const { 134 const std::string& guid) const {
135 // TODO(dimich): when requests are also in the cache, filter them out. 135 // TODO(dimich): when requests are also in the cache, filter them out.
136 // Requests do not yet have offline URL. 136 // Requests do not yet have offline ID.
137 DownloadUIItems::const_iterator it = items_.find(guid); 137 DownloadUIItems::const_iterator it = items_.find(guid);
138 if (it != items_.end()) 138 if (it != items_.end())
139 return it->second->offline_url; 139 return it->second->offline_id;
140 return GURL(); 140 return 0;
141 } 141 }
142 142
143 // Note that several LoadCache calls may be issued before the async GetAllPages 143 // Note that several LoadCache calls may be issued before the async GetAllPages
144 // comes back. 144 // comes back.
145 void DownloadUIAdapter::LoadCache() { 145 void DownloadUIAdapter::LoadCache() {
146 // TODO(dimich): Add fetching from RequestQueue as well. 146 // TODO(dimich): Add fetching from RequestQueue as well.
147 state_ = State::LOADING; 147 state_ = State::LOADING;
148 model_->GetAllPages( 148 model_->GetAllPages(
149 base::Bind(&DownloadUIAdapter::OnOfflinePagesLoaded, 149 base::Bind(&DownloadUIAdapter::OnOfflinePagesLoaded,
150 weak_ptr_factory_.GetWeakPtr())); 150 weak_ptr_factory_.GetWeakPtr()));
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
211 } 211 }
212 212
213 // static 213 // static
214 bool DownloadUIAdapter::IsVisibleInUI(const ClientId& client_id) { 214 bool DownloadUIAdapter::IsVisibleInUI(const ClientId& client_id) {
215 const std::string& name_space = client_id.name_space; 215 const std::string& name_space = client_id.name_space;
216 return (name_space == kAsyncNamespace || name_space == kDownloadNamespace) && 216 return (name_space == kAsyncNamespace || name_space == kDownloadNamespace) &&
217 base::IsValidGUID(client_id.id); 217 base::IsValidGUID(client_id.id);
218 } 218 }
219 219
220 } // namespace offline_pages 220 } // namespace offline_pages
OLDNEW
« no previous file with comments | « components/offline_pages/downloads/download_ui_adapter.h ('k') | components/offline_pages/offline_page_model_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698