Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc

Issue 2322833002: Support serving offline page by offline ID (Closed)
Patch Set: Remove unused variable to fix trybot Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
diff --git a/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc b/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
index 900c67a4366435a8f851e03a82f8e2c9edacfa11..7047d5b5a7f6219dd8435227d1c46ee36237a71d 100644
--- a/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
+++ b/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
@@ -191,15 +191,12 @@ void OfflinePageDownloadBridge::DeleteItemByGuid(
download_ui_adapter_->DeleteItem(guid);
}
-ScopedJavaLocalRef<jstring> OfflinePageDownloadBridge::GetOfflineUrlByGuid(
+jlong OfflinePageDownloadBridge::GetOfflineIdByGuid(
JNIEnv* env,
const JavaParamRef<jobject>& obj,
const JavaParamRef<jstring>& j_guid) {
std::string guid = ConvertJavaStringToUTF8(env, j_guid);
- GURL url = download_ui_adapter_->GetOfflineUrlByGuid(guid);
- if (!url.is_valid())
- return ScopedJavaLocalRef<jstring>();
- return ConvertUTF8ToJavaString(env, url.spec());
+ return download_ui_adapter_->GetOfflineIdByGuid(guid);
}
void OfflinePageDownloadBridge::StartDownload(

Powered by Google App Engine
This is Rietveld 408576698