Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Side by Side Diff: chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc

Issue 2322833002: Support serving offline page by offline ID (Closed)
Patch Set: Remove unused variable to fix trybot Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/offline_pages/downloads/offline_page_download_b ridge.h" 5 #include "chrome/browser/android/offline_pages/downloads/offline_page_download_b ridge.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/android/jni_string.h" 9 #include "base/android/jni_string.h"
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
184 } 184 }
185 185
186 void OfflinePageDownloadBridge::DeleteItemByGuid( 186 void OfflinePageDownloadBridge::DeleteItemByGuid(
187 JNIEnv* env, 187 JNIEnv* env,
188 const JavaParamRef<jobject>& obj, 188 const JavaParamRef<jobject>& obj,
189 const JavaParamRef<jstring>& j_guid) { 189 const JavaParamRef<jstring>& j_guid) {
190 std::string guid = ConvertJavaStringToUTF8(env, j_guid); 190 std::string guid = ConvertJavaStringToUTF8(env, j_guid);
191 download_ui_adapter_->DeleteItem(guid); 191 download_ui_adapter_->DeleteItem(guid);
192 } 192 }
193 193
194 ScopedJavaLocalRef<jstring> OfflinePageDownloadBridge::GetOfflineUrlByGuid( 194 jlong OfflinePageDownloadBridge::GetOfflineIdByGuid(
195 JNIEnv* env, 195 JNIEnv* env,
196 const JavaParamRef<jobject>& obj, 196 const JavaParamRef<jobject>& obj,
197 const JavaParamRef<jstring>& j_guid) { 197 const JavaParamRef<jstring>& j_guid) {
198 std::string guid = ConvertJavaStringToUTF8(env, j_guid); 198 std::string guid = ConvertJavaStringToUTF8(env, j_guid);
199 GURL url = download_ui_adapter_->GetOfflineUrlByGuid(guid); 199 return download_ui_adapter_->GetOfflineIdByGuid(guid);
200 if (!url.is_valid())
201 return ScopedJavaLocalRef<jstring>();
202 return ConvertUTF8ToJavaString(env, url.spec());
203 } 200 }
204 201
205 void OfflinePageDownloadBridge::StartDownload( 202 void OfflinePageDownloadBridge::StartDownload(
206 JNIEnv* env, 203 JNIEnv* env,
207 const JavaParamRef<jobject>& obj, 204 const JavaParamRef<jobject>& obj,
208 const JavaParamRef<jobject>& j_tab) { 205 const JavaParamRef<jobject>& j_tab) {
209 TabAndroid* tab = TabAndroid::GetNativeTab(env, j_tab); 206 TabAndroid* tab = TabAndroid::GetNativeTab(env, j_tab);
210 if (!tab) 207 if (!tab)
211 return; 208 return;
212 209
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
352 349
353 DownloadUIAdapter* adapter = 350 DownloadUIAdapter* adapter =
354 DownloadUIAdapter::FromOfflinePageModel(offline_page_model); 351 DownloadUIAdapter::FromOfflinePageModel(offline_page_model);
355 352
356 return reinterpret_cast<jlong>( 353 return reinterpret_cast<jlong>(
357 new OfflinePageDownloadBridge(env, obj, adapter, browser_context)); 354 new OfflinePageDownloadBridge(env, obj, adapter, browser_context));
358 } 355 }
359 356
360 } // namespace android 357 } // namespace android
361 } // namespace offline_pages 358 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698