Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2322703002: Revert of Copy float list of ruby base when merging it with a sibling (Closed)

Created:
4 years, 3 months ago by Will Harris
Modified:
4 years, 3 months ago
Reviewers:
rhogan, eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Copy float list of ruby base when merging it with a sibling (patchset #1 id:1 of https://codereview.chromium.org/2283413003/ ) Reason for revert: see crbug.com/644605 Original issue's description: > Copy float list of ruby base when merging it with a sibling > > When merging two ruby bases ensure that the new base has a complete float list. > > BUG=619380, 624028 > > Committed: https://crrev.com/6f208d569f6bd2488f2f2f6f9004e54417f78782 > Cr-Commit-Position: refs/heads/master@{#415337} TBR=eae@chromium.org,robhogan@gmail.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=619380, 624028, 644605 Committed: https://crrev.com/f6e18a33072f5811932ecafe3b6c314591b3fdc8 Cr-Commit-Position: refs/heads/master@{#417825}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -25 lines) Patch
M third_party/WebKit/LayoutTests/fast/block/float/float-reparent-during-detach-crash.html View 1 chunk +17 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/layout/FloatingObjects.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/FloatingObjects.cpp View 3 chunks +11 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutRubyBase.cpp View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Will Harris
Created Revert of Copy float list of ruby base when merging it with a sibling
4 years, 3 months ago (2016-09-07 21:13:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2322703002/1
4 years, 3 months ago (2016-09-07 21:14:46 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/289108)
4 years, 3 months ago (2016-09-08 01:02:16 UTC) #6
eae
LGTM :(
4 years, 3 months ago (2016-09-08 07:36:01 UTC) #7
Will Harris
On 2016/09/08 07:36:01, eae wrote: > LGTM :( sorry :(
4 years, 3 months ago (2016-09-08 18:35:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2322703002/1
4 years, 3 months ago (2016-09-10 07:19:17 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-10 09:03:41 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-10 09:05:14 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f6e18a33072f5811932ecafe3b6c314591b3fdc8
Cr-Commit-Position: refs/heads/master@{#417825}

Powered by Google App Engine
This is Rietveld 408576698