Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2322693003: CC Animation: Rename has_any_animation and make implementattion out-of-line (Closed)

Created:
4 years, 3 months ago by loyso (OOO)
Modified:
4 years, 3 months ago
Reviewers:
ajuma
CC:
chromium-reviews, Ian Vollick, sievers+watch_chromium.org, jbauman+watch_chromium.org, piman+watch_chromium.org, kalyank, cc-bugs_chromium.org, danakj+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC Animation: Rename has_any_animation and make implementattion out-of-line This is a preparation to erase animations_ data stored in ElementAnimation. BUG=592873 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/12e8a82c15eb5ca6ef95ad0c0e0bf00564c1a37d Cr-Commit-Position: refs/heads/master@{#417531}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M cc/animation/animation_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/animation/animation_player.h View 1 chunk +2 lines, -4 lines 0 comments Download
M cc/animation/element_animations.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/animation/element_animations.cc View 2 chunks +5 lines, -1 line 0 comments Download
M cc/animation/element_animations_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M ui/compositor/layer_animator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
loyso (OOO)
4 years, 3 months ago (2016-09-08 05:19:08 UTC) #6
ajuma
lgtm
4 years, 3 months ago (2016-09-08 14:38:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2322693003/1
4 years, 3 months ago (2016-09-09 06:17:47 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 07:54:44 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 07:57:03 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12e8a82c15eb5ca6ef95ad0c0e0bf00564c1a37d
Cr-Commit-Position: refs/heads/master@{#417531}

Powered by Google App Engine
This is Rietveld 408576698