Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: components/autofill/content/browser/request_autocomplete_manager_unittest.cc

Issue 232263002: Console logging for rAc developer errors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: improvements Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/browser/request_autocomplete_manager_unittest.cc
diff --git a/components/autofill/content/browser/request_autocomplete_manager_unittest.cc b/components/autofill/content/browser/request_autocomplete_manager_unittest.cc
index a1cf2596cb44547860dfe37b83d1acb3d79074ed..c5d17646e1646bcc6b9331347cbaf3df004a4a42 100644
--- a/components/autofill/content/browser/request_autocomplete_manager_unittest.cc
+++ b/components/autofill/content/browser/request_autocomplete_manager_unittest.cc
@@ -51,9 +51,12 @@ class CustomTestAutofillManagerDelegate : public TestAutofillManagerDelegate {
const ResultCallback& callback) OVERRIDE {
if (should_simulate_success_) {
FormStructure form_structure(form);
- callback.Run(AutocompleteResultSuccess, &form_structure);
+ callback.Run(AutocompleteResultSuccess,
+ base::string16(),
Dan Beam 2014/04/10 01:14:51 nit: maybe add your fake messages here as well?
+ &form_structure);
} else {
callback.Run(AutofillManagerDelegate::AutocompleteResultErrorDisabled,
+ base::string16(),
NULL);
}
}
@@ -124,7 +127,8 @@ class RequestAutocompleteManagerTest :
process()->sink().GetFirstMessageMatching(kMsgID);
if (!message)
return false;
- Tuple2<blink::WebFormElement::AutocompleteResult, FormData> autofill_param;
+ Tuple3<blink::WebFormElement::AutocompleteResult, base::string16, FormData>
+ autofill_param;
AutofillMsg_RequestAutocompleteResult::Read(message, &autofill_param);
*result = autofill_param.a;
process()->sink().ClearMessages();

Powered by Google App Engine
This is Rietveld 408576698