[Remoting Android] Fix OnPixelTransformationChanged Flakiness

[Remoting Android] Fix OnPixelTransformationChanged Flakiness

In very rare circumstance (<5% connection attempt)
GlRenderer::OnPixelTransformationChanged is called when SurfaceCreated has not
been called, which crashes the app since |canvas_| has not been set. This CL
adds check for |canvas_| to prevent crashing. For now we don't know in that
case whether the transformation was set before SurfaceCreated or the surface
had actually been created before the surface callback was registered. If former
is true then this CL will fix the problem since SurfaceCreated will implicitly
cause TransformationChanged. If latter is true then nothing will be drawn on
the view although the app doesn't crash, and we will need to investigate why
this can ever happen.

BUG=644924
Committed: https://crrev.com/ac2e73718fbdfbb5cb5458a1271339174deec8ef
Cr-Commit-Position: refs/heads/master@{#417463}

[Yuwei, 2016-09-07 22:53:40]

Description was changed from

==========
[Remoting Android] Fix OnPixelTransformationChanged Flakiness

In very rare circumstance (<5% connection attempt)
GlRenderer::OnPixelTransformationChanged is called when SurfaceCreated has not
been called, which crashes the app since |canvas_| has not been set. This CL
adds check for |canvas_| to prevent crashing. For now we don't know in that
case whether the transformation was set before SurfaceCreated or the surface
had actually been created before the surface callback was registered. If former
is true then this CL will fix the problem since SurfaceCreated will implicitly
cause TransformationChanged. If latter is true then nothing will be drawn on
the view although the app doesn't crash, and we will need to investigate why
this can ever happen.
==========

to

==========
[Remoting Android] Fix OnPixelTransformationChanged Flakiness

In very rare circumstance (<5% connection attempt)
GlRenderer::OnPixelTransformationChanged is called when SurfaceCreated has not
been called, which crashes the app since |canvas_| has not been set. This CL
adds check for |canvas_| to prevent crashing. For now we don't know in that
case whether the transformation was set before SurfaceCreated or the surface
had actually been created before the surface callback was registered. If former
is true then this CL will fix the problem since SurfaceCreated will implicitly
cause TransformationChanged. If latter is true then nothing will be drawn on
the view although the app doesn't crash, and we will need to investigate why
this can ever happen.

BUG=644924
==========

[Yuwei, 2016-09-07 22:55:40]

yuweih@chromium.org changed reviewers:
+ lambroslambrou@chromium.org, sergeyu@chromium.org

[Yuwei, 2016-09-07 22:55:41]

PTAL

[Yuwei, 2016-09-07 23:13:31]

More inclined to the first explanation. Tried rotating the screen for hundreds
of times and only got one warning but no black screen.

[Yuwei, 2016-09-08 23:15:16]

On 2016/09/07 23:13:31, Yuwei wrote:
> More inclined to the first explanation. Tried rotating the screen for hundreds
> of times and only got one warning but no black screen.

Ping!

[Sergey Ulanov, 2016-09-08 23:21:04]

lgtm

https://codereview.chromium.org/2322623003/diff/1/remoting/client/gl_renderer.cc
File remoting/client/gl_renderer.cc (right):

https://codereview.chromium.org/2322623003/diff/1/remoting/client/gl_renderer...
remoting/client/gl_renderer.cc:44: << "not ready.";
nit: remove <<

[Yuwei, 2016-09-08 23:31:51]

Thanks!

https://codereview.chromium.org/2322623003/diff/1/remoting/client/gl_renderer.cc
File remoting/client/gl_renderer.cc (right):

https://codereview.chromium.org/2322623003/diff/1/remoting/client/gl_renderer...
remoting/client/gl_renderer.cc:44: << "not ready.";
On 2016/09/08 23:21:04, Sergey Ulanov wrote:
> nit: remove <<

Done.

[Yuwei, 2016-09-08 23:32:00]

The CQ bit was checked by yuweih@chromium.org

[Yuwei, 2016-09-08 23:32:01]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/2322623003/#ps20001
(title: "Reviewer's Feedback")

[commit-bot: I haz the power, 2016-09-08 23:32:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 00:51:44]

Description was changed from

==========
[Remoting Android] Fix OnPixelTransformationChanged Flakiness

In very rare circumstance (<5% connection attempt)
GlRenderer::OnPixelTransformationChanged is called when SurfaceCreated has not
been called, which crashes the app since |canvas_| has not been set. This CL
adds check for |canvas_| to prevent crashing. For now we don't know in that
case whether the transformation was set before SurfaceCreated or the surface
had actually been created before the surface callback was registered. If former
is true then this CL will fix the problem since SurfaceCreated will implicitly
cause TransformationChanged. If latter is true then nothing will be drawn on
the view although the app doesn't crash, and we will need to investigate why
this can ever happen.

BUG=644924
==========

to

==========
[Remoting Android] Fix OnPixelTransformationChanged Flakiness

In very rare circumstance (<5% connection attempt)
GlRenderer::OnPixelTransformationChanged is called when SurfaceCreated has not
been called, which crashes the app since |canvas_| has not been set. This CL
adds check for |canvas_| to prevent crashing. For now we don't know in that
case whether the transformation was set before SurfaceCreated or the surface
had actually been created before the surface callback was registered. If former
is true then this CL will fix the problem since SurfaceCreated will implicitly
cause TransformationChanged. If latter is true then nothing will be drawn on
the view although the app doesn't crash, and we will need to investigate why
this can ever happen.

BUG=644924
==========

[commit-bot: I haz the power, 2016-09-09 00:51:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-09 00:53:35]

Description was changed from

==========
[Remoting Android] Fix OnPixelTransformationChanged Flakiness

In very rare circumstance (<5% connection attempt)
GlRenderer::OnPixelTransformationChanged is called when SurfaceCreated has not
been called, which crashes the app since |canvas_| has not been set. This CL
adds check for |canvas_| to prevent crashing. For now we don't know in that
case whether the transformation was set before SurfaceCreated or the surface
had actually been created before the surface callback was registered. If former
is true then this CL will fix the problem since SurfaceCreated will implicitly
cause TransformationChanged. If latter is true then nothing will be drawn on
the view although the app doesn't crash, and we will need to investigate why
this can ever happen.

BUG=644924
==========

to

==========
[Remoting Android] Fix OnPixelTransformationChanged Flakiness

In very rare circumstance (<5% connection attempt)
GlRenderer::OnPixelTransformationChanged is called when SurfaceCreated has not
been called, which crashes the app since |canvas_| has not been set. This CL
adds check for |canvas_| to prevent crashing. For now we don't know in that
case whether the transformation was set before SurfaceCreated or the surface
had actually been created before the surface callback was registered. If former
is true then this CL will fix the problem since SurfaceCreated will implicitly
cause TransformationChanged. If latter is true then nothing will be drawn on
the view although the app doesn't crash, and we will need to investigate why
this can ever happen.

BUG=644924

Committed: https://crrev.com/ac2e73718fbdfbb5cb5458a1271339174deec8ef
Cr-Commit-Position: refs/heads/master@{#417463}
==========

[commit-bot: I haz the power, 2016-09-09 00:53:40]

Patchset 2 (id:??) landed as
https://crrev.com/ac2e73718fbdfbb5cb5458a1271339174deec8ef
Cr-Commit-Position: refs/heads/master@{#417463}