Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: remoting/client/gl_renderer.cc

Issue 2322623003: [Remoting Android] Fix OnPixelTransformationChanged Flakiness (Closed)
Patch Set: Reviewer's Feedback Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/client/gl_renderer.cc
diff --git a/remoting/client/gl_renderer.cc b/remoting/client/gl_renderer.cc
index 88ce9c2065ce9b9e58ec255a0c1592e8361d3166..77011b7f7db20fa2e6cace1277d9f5e35ee2aa55 100644
--- a/remoting/client/gl_renderer.cc
+++ b/remoting/client/gl_renderer.cc
@@ -39,6 +39,11 @@ void GlRenderer::RequestCanvasSize() {
void GlRenderer::OnPixelTransformationChanged(
const std::array<float, 9>& matrix) {
DCHECK(thread_checker_.CalledOnValidThread());
+ if (!canvas_) {
+ LOG(WARNING) << "Trying to set transformation matrix when the canvas is "
+ "not ready.";
+ return;
+ }
canvas_->SetTransformationMatrix(matrix);
RequestRender();
}
@@ -97,6 +102,10 @@ void GlRenderer::OnSurfaceCreated(int gl_version) {
void GlRenderer::OnSurfaceChanged(int view_width, int view_height) {
DCHECK(thread_checker_.CalledOnValidThread());
+ if (!canvas_) {
+ LOG(WARNING) << "Trying to set the view size when the canvas is not ready.";
+ return;
+ }
canvas_->SetViewSize(view_width, view_height);
RequestRender();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698