Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(11)

Issue 2322573002: misc files A-P: Change ScopedTempDir::path() to GetPath() (Closed)

Created:
4 years, 6 months ago by vabr (Chromium)
Modified:
4 years, 5 months ago
CC:
Aaron Boodman, abarth-chromium, alokp+watch_chromium.org, anandc+watch-blimp_chromium.org, android-webview-reviews_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, dtrainor+watch-blimp_chromium.org, fukino+watch_chromium.org, gcasto+watch-blimp_chromium.org, halliwell+watch_chromium.org, jam, jessicag+watch-blimp_chromium.org, johnme+watch_chromium.org, kalyank, khushalsagar+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lcwu+watch_chromium.org, lethalantidote+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, oka+watch_chromium.org, Peter Beverloo, qsr+mojo_chromium.org, sadrul, sdefresne+watch_chromium.org, shaktisahu+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, tfarina, viettrungluu+watch_chromium.org, yamaguchi+watch_chromium.org, yzshen+watch_chromium.org, zea+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

misc files A-P: Change ScopedTempDir::path() to GetPath() path() is being deprecated, GetPath() has better checking against wrong use. For more context, see https://codereview.chromium.org/2275553005/. BUG=640599 TBR=rsleevi@chromium.org, alexclarke@chromium.org, vitalybuka@chromium.org, nyquist@chromium.org, boliu@chromium.org, benwells@chromium.org, sdefresne@chromium.org, rogerta@chromium.org, rockot@chromium.org, alokp@chromium.org Committed: https://crrev.com/16e5f602ab9d2b89473daf8a85c28fe448528895 Cr-Commit-Position: refs/heads/master@{#418904}

Patch Set 1 #

Patch Set 2 : Just rebased #

Patch Set 3 : Revert chromecast/base/serializers_unittest.cc #

Patch Set 4 : Just rebased #

Patch Set 5 : Just rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -53 lines) Patch
M android_webview/browser/aw_form_database_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M apps/app_restore_service_browsertest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M blimp/engine/app/blimp_engine_config_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/app/linux/cast_crash_reporter_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/base/error_codes_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromecast/crash/linux/dummy_minidump_generator_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chromecast/crash/linux/minidump_uploader_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromecast/crash/linux/minidump_writer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromecast/crash/linux/synchronized_minidump_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M crypto/scoped_test_nss_chromeos_user.cc View 1 chunk +1 line, -1 line 0 comments Download
M crypto/scoped_test_nss_db.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/drive/base_requests_server_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/drive/drive_api_requests_unittest.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M google_apis/gcm/engine/gcm_store_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/mcs_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M headless/lib/headless_browser_context_browsertest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M ios/chrome/browser/browser_state/test_chrome_browser_state.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M ipc/attachment_broker_mac_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/attachment_broker_privileged_win_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ipc/ipc_channel_mojo_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/embedder/platform_channel_pair_posix_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/multiprocess_message_pipe_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/platform_handle_dispatcher_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M printing/emf_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 28 (18 generated)
vabr (Chromium)
Hello reviewers, This CL is purely a mechanical change (renaming path->GetPath + formatting). In accordance ...
4 years, 5 months ago (2016-09-15 14:14:39 UTC) #13
vabr (Chromium)
Hello alokp@chromium.org, I'm adding you in TBR for the trivial changes in chromecast/*. Thank you! ...
4 years, 5 months ago (2016-09-15 14:26:07 UTC) #16
boliu
lgtm
4 years, 5 months ago (2016-09-15 14:28:10 UTC) #17
Roger Tawa OOO till Jul 10th
lgtm google_apis
4 years, 5 months ago (2016-09-15 14:40:43 UTC) #18
nyquist
blimp lgtm
4 years, 5 months ago (2016-09-15 14:43:03 UTC) #19
Ryan Sleevi
crypto/ LGTM
4 years, 5 months ago (2016-09-15 16:07:02 UTC) #20
Ken Rockot(use gerrit already)
ipc/ and mojo/ LGTM
4 years, 5 months ago (2016-09-15 16:12:37 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2322573002/80001
4 years, 5 months ago (2016-09-15 17:24:26 UTC) #24
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 5 months ago (2016-09-15 18:14:27 UTC) #26
commit-bot: I haz the power
4 years, 5 months ago (2016-09-15 18:16:22 UTC) #28
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/16e5f602ab9d2b89473daf8a85c28fe448528895
Cr-Commit-Position: refs/heads/master@{#418904}

Powered by Google App Engine
This is Rietveld 408576698