Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(901)

Issue 2322333003: [headless] Call StopLocalDevToolsHttpHandler only when needed. (Closed)

Created:
4 years, 3 months ago by altimin
Modified:
4 years, 3 months ago
Reviewers:
Sami
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[headless] Call StopLocalDevToolsHttpHandler only when needed. This fixes test crashes on headless buildbot. BUG=632008 Committed: https://crrev.com/366e76721f37fd25d860c2c3f76d6b43d610abc3 Cr-Commit-Position: refs/heads/master@{#417630}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M headless/lib/browser/headless_browser_main_parts.h View 1 chunk +2 lines, -0 lines 0 comments Download
M headless/lib/browser/headless_browser_main_parts.cc View 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
altimin
4 years, 3 months ago (2016-09-09 16:46:08 UTC) #3
Sami
lgtm, thanks for the fix!
4 years, 3 months ago (2016-09-09 17:08:14 UTC) #4
Sami
lgtm, thanks for the fix!
4 years, 3 months ago (2016-09-09 17:08:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2322333003/1
4 years, 3 months ago (2016-09-09 17:12:02 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 18:06:05 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 18:08:31 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/366e76721f37fd25d860c2c3f76d6b43d610abc3
Cr-Commit-Position: refs/heads/master@{#417630}

Powered by Google App Engine
This is Rietveld 408576698