Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: headless/lib/browser/headless_browser_main_parts.cc

Issue 2322333003: [headless] Call StopLocalDevToolsHttpHandler only when needed. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « headless/lib/browser/headless_browser_main_parts.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "headless/lib/browser/headless_browser_main_parts.h" 5 #include "headless/lib/browser/headless_browser_main_parts.h"
6 6
7 #include "headless/lib/browser/headless_browser_context_impl.h" 7 #include "headless/lib/browser/headless_browser_context_impl.h"
8 #include "headless/lib/browser/headless_browser_impl.h" 8 #include "headless/lib/browser/headless_browser_impl.h"
9 #include "headless/lib/browser/headless_devtools.h" 9 #include "headless/lib/browser/headless_devtools.h"
10 #include "headless/lib/browser/headless_screen.h" 10 #include "headless/lib/browser/headless_screen.h"
11 #include "ui/aura/env.h" 11 #include "ui/aura/env.h"
12 #include "ui/display/screen.h" 12 #include "ui/display/screen.h"
13 13
14 namespace headless { 14 namespace headless {
15 15
16 namespace { 16 namespace {
17 17
18 void PlatformInitialize(const gfx::Size& screen_size) { 18 void PlatformInitialize(const gfx::Size& screen_size) {
19 HeadlessScreen* screen = HeadlessScreen::Create(screen_size); 19 HeadlessScreen* screen = HeadlessScreen::Create(screen_size);
20 display::Screen::SetScreenInstance(screen); 20 display::Screen::SetScreenInstance(screen);
21 } 21 }
22 22
23 void PlatformExit() { 23 void PlatformExit() {
24 } 24 }
25 25
26 } // namespace 26 } // namespace
27 27
28 HeadlessBrowserMainParts::HeadlessBrowserMainParts(HeadlessBrowserImpl* browser) 28 HeadlessBrowserMainParts::HeadlessBrowserMainParts(HeadlessBrowserImpl* browser)
29 : browser_(browser) {} 29 : browser_(browser)
30 , devtools_http_handler_started_(false) {}
30 31
31 HeadlessBrowserMainParts::~HeadlessBrowserMainParts() {} 32 HeadlessBrowserMainParts::~HeadlessBrowserMainParts() {}
32 33
33 void HeadlessBrowserMainParts::PreMainMessageLoopRun() { 34 void HeadlessBrowserMainParts::PreMainMessageLoopRun() {
34 if (browser_->options()->devtools_endpoint.address().IsValid()) 35 if (browser_->options()->devtools_endpoint.address().IsValid()) {
35 StartLocalDevToolsHttpHandler(browser_->options()); 36 StartLocalDevToolsHttpHandler(browser_->options());
37 devtools_http_handler_started_ = true;
38 }
36 PlatformInitialize(browser_->options()->window_size); 39 PlatformInitialize(browser_->options()->window_size);
37 } 40 }
38 41
39 void HeadlessBrowserMainParts::PostMainMessageLoopRun() { 42 void HeadlessBrowserMainParts::PostMainMessageLoopRun() {
40 StopLocalDevToolsHttpHandler(); 43 if (devtools_http_handler_started_) {
44 StopLocalDevToolsHttpHandler();
45 devtools_http_handler_started_ = false;
46 }
41 PlatformExit(); 47 PlatformExit();
42 } 48 }
43 49
44 } // namespace headless 50 } // namespace headless
OLDNEW
« no previous file with comments | « headless/lib/browser/headless_browser_main_parts.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698