Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issue 2322153003: Revert "Move on-demand update checks from the FILE thread to the blocking pool." (Closed)

Created:
4 years, 3 months ago by grt (UTC plus 2)
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Revert "Move on-demand update checks from the FILE thread to the blocking pool." This reverts commit 12cdde78e334c9380bb0b07a85a1198d0094cfe0 (and a80b84bf1ce305677f7eb99f0a9dbbff8904aa2f since it only impacted the new code in the aforementioned commit). Reason for revert: Threads in the blocking pool do not pump Windows messages, which is required for correct functioning of the global interface table; see https://crbug.com/644687. BUG=2462, 644687 TBR=pkasting@chromium.org Review-Url: https://codereview.chromium.org/2318073002 Cr-Commit-Position: refs/heads/master@{#416918} (cherry picked from commit 9f391dd808620d168b5ef7587799c26d734b324e) TBR=grt@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/28da2248ab0ce98128a63fb2f2a416ee2a6eb11b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -333 lines) Patch
M chrome/browser/google/google_update_win.h View 2 chunks +14 lines, -19 lines 0 comments Download
M chrome/browser/google/google_update_win.cc View 23 chunks +79 lines, -212 lines 0 comments Download
M chrome/browser/google/google_update_win_unittest.cc View 11 chunks +22 lines, -93 lines 0 comments Download
M chrome/browser/ui/webui/help/version_updater_win.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/help/version_updater_win.cc View 3 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
grt (UTC plus 2)
4 years, 3 months ago (2016-09-09 11:56:08 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
28da2248ab0ce98128a63fb2f2a416ee2a6eb11b.

Powered by Google App Engine
This is Rietveld 408576698