Revert "Move on-demand update checks from the FILE thread to the blocking pool."

Revert "Move on-demand update checks from the FILE thread to the blocking pool."

This reverts commit 12cdde78e334c9380bb0b07a85a1198d0094cfe0 (and
a80b84bf1ce305677f7eb99f0a9dbbff8904aa2f since it only impacted the new
code in the aforementioned commit).

Reason for revert: Threads in the blocking pool do not pump Windows
messages, which is required for correct functioning of the global
interface table; see https://crbug.com/644687.

BUG=2462, 644687
TBR=pkasting@chromium.org

Committed: https://crrev.com/9f391dd808620d168b5ef7587799c26d734b324e
Cr-Commit-Position: refs/heads/master@{#416918}

[grt (UTC plus 2), 2016-09-07 11:32:03]

Patchset #1 (id:1) has been deleted

[grt (UTC plus 2), 2016-09-07 11:35:51]

Description was changed from

==========
Revert "Move on-demand update checks from the FILE thread to the blocking pool."

This reverts commit 12cdde78e334c9380bb0b07a85a1198d0094cfe0.

Reason for revert: Threads in the blocking pool do not pump Windows
messages, which is required for correct functioning of the global
interface table; see https://crbug.com/644687.

BUG=2462,644687
TBR=pkasting@chromium.org
==========

to

==========
Revert "Move on-demand update checks from the FILE thread to the blocking pool."

This reverts commit 12cdde78e334c9380bb0b07a85a1198d0094cfe0 (and
a80b84bf1ce305677f7eb99f0a9dbbff8904aa2f since it only impacted the new
code in the aforementioned commit).

Reason for revert: Threads in the blocking pool do not pump Windows
messages, which is required for correct functioning of the global
interface table; see https://crbug.com/644687.

BUG=2462,644687
TBR=pkasting@chromium.org
==========

[grt (UTC plus 2), 2016-09-07 11:36:50]

This is a 100% revert with no additional edits. Landing with TBR. Feel free to
review or ignore as you wish.

[grt (UTC plus 2), 2016-09-07 11:36:54]

The CQ bit was checked by grt@chromium.org

[commit-bot: I haz the power, 2016-09-07 11:37:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 11:39:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 11:39:29]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[grt (UTC plus 2), 2016-09-07 12:11:05]

The CQ bit was checked by grt@chromium.org

[commit-bot: I haz the power, 2016-09-07 12:11:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 12:49:52]

Description was changed from

==========
Revert "Move on-demand update checks from the FILE thread to the blocking pool."

This reverts commit 12cdde78e334c9380bb0b07a85a1198d0094cfe0 (and
a80b84bf1ce305677f7eb99f0a9dbbff8904aa2f since it only impacted the new
code in the aforementioned commit).

Reason for revert: Threads in the blocking pool do not pump Windows
messages, which is required for correct functioning of the global
interface table; see https://crbug.com/644687.

BUG=2462,644687
TBR=pkasting@chromium.org
==========

to

==========
Revert "Move on-demand update checks from the FILE thread to the blocking pool."

This reverts commit 12cdde78e334c9380bb0b07a85a1198d0094cfe0 (and
a80b84bf1ce305677f7eb99f0a9dbbff8904aa2f since it only impacted the new
code in the aforementioned commit).

Reason for revert: Threads in the blocking pool do not pump Windows
messages, which is required for correct functioning of the global
interface table; see https://crbug.com/644687.

BUG=2462,644687
TBR=pkasting@chromium.org
==========

[commit-bot: I haz the power, 2016-09-07 12:49:53]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-09-07 12:51:52]

Description was changed from

==========
Revert "Move on-demand update checks from the FILE thread to the blocking pool."

This reverts commit 12cdde78e334c9380bb0b07a85a1198d0094cfe0 (and
a80b84bf1ce305677f7eb99f0a9dbbff8904aa2f since it only impacted the new
code in the aforementioned commit).

Reason for revert: Threads in the blocking pool do not pump Windows
messages, which is required for correct functioning of the global
interface table; see https://crbug.com/644687.

BUG=2462,644687
TBR=pkasting@chromium.org
==========

to

==========
Revert "Move on-demand update checks from the FILE thread to the blocking pool."

This reverts commit 12cdde78e334c9380bb0b07a85a1198d0094cfe0 (and
a80b84bf1ce305677f7eb99f0a9dbbff8904aa2f since it only impacted the new
code in the aforementioned commit).

Reason for revert: Threads in the blocking pool do not pump Windows
messages, which is required for correct functioning of the global
interface table; see https://crbug.com/644687.

BUG=2462,644687
TBR=pkasting@chromium.org

Committed: https://crrev.com/9f391dd808620d168b5ef7587799c26d734b324e
Cr-Commit-Position: refs/heads/master@{#416918}
==========

[commit-bot: I haz the power, 2016-09-07 12:51:53]

Patchset 2 (id:??) landed as
https://crrev.com/9f391dd808620d168b5ef7587799c26d734b324e
Cr-Commit-Position: refs/heads/master@{#416918}

[Peter Kasting, 2016-09-07 19:53:06]

RS LGTM

Good luck getting all this fixed...

[grt (UTC plus 2), 2016-09-07 19:57:25]

On 2016/09/07 19:53:06, Peter Kasting wrote:
> RS LGTM
> 
> Good luck getting all this fixed...

Thanks. At least I'm learning stuff. :-)