[Findit] Add cracas_crash_analysis

appengine/findit/model/crash/cracas_crash_analysis.py

Index: appengine/findit/model/crash/cracas_crash_analysis.py
diff --git a/appengine/findit/model/crash/cracas_crash_analysis.py b/appengine/findit/model/crash/cracas_crash_analysis.py
new file mode 100644
index 0000000000000000000000000000000000000000..f8ec169ffc27776f14fc9afc5dd75ddbd8315223
--- /dev/null
+++ b/appengine/findit/model/crash/cracas_crash_analysis.py
@@ -0,0 +1,20 @@
+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import hashlib
+import json
+
+from google.appengine.ext import ndb
+
+from model.crash.fracas_crash_analysis import FracasCrashAnalysis
+
+# TODO(katesonia): Deprecate FracasCrashAnalysis after switching from Fracas
+# to Cracas.
+class CracasCrashAnalysis(FracasCrashAnalysis):

[wrengr (wrong one), 2016/09/09 17:58:24]

Like mbarbella says, this doesn't look clean. Especially given the intent to
deprecate FracasCrashAnalysis in the (presumably near) future, it'd be a lot
better to just factor things out now. There should be some base class that
contains the historic metadata and whatever else is shared, and then both the
FracasCrashAnalysis and CracasCrashAnalysis will be thin subclasses that only
override the method you mentioned. (Whether the shared base class is the same as
CrashAnalysis or different is up to you.)

Classes are cheap. Use them freely to help organize the code, name key concepts,
and keep concerns separate. Even when there's only one small difference between
a subclass and its superclass, if the classes are doing conceptually different
things then make them different classes. The class hierarchy should match the
conceptual ontology; since CracasCrashAnalysis isn't "a type of"
FracasCrashAnalysis, it shouldn't inherit from there.

[Sharu Jiang, 2016/09/09 23:19:42]

Done.

+  """Represents an analysis of a Chrome crash."""
+
+  @staticmethod
+  def _CreateKey(crash_identifiers):
+    return ndb.Key('CracasCrashAnalysis', hashlib.sha1(
+        json.dumps(crash_identifiers, sort_keys=True)).hexdigest())