Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: appengine/findit/crash/findit_for_client.py

Issue 2322133002: [Findit] Add cracas_crash_analysis (Closed)
Patch Set: Overwrite _CreateKey method. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/crash/findit_for_client.py
diff --git a/appengine/findit/crash/findit_for_client.py b/appengine/findit/crash/findit_for_client.py
index 2f45df79f83a7e22cd2be92109efcda99432672e..8075a0b3fa1cc2521997cac7b7041f2b4882b2fd 100644
--- a/appengine/findit/crash/findit_for_client.py
+++ b/appengine/findit/crash/findit_for_client.py
@@ -15,6 +15,7 @@ from crash.type_enums import CrashClient
from model import analysis_status
from model.crash.crash_config import CrashConfig
from model.crash.fracas_crash_analysis import FracasCrashAnalysis
+from model.crash.cracas_crash_analysis import CracasCrashAnalysis
_FINDIT_FRACAS_FEEDBACK_URL_TEMPLATE = '%s/crash/fracas-result-feedback?key=%s'
@@ -65,8 +66,7 @@ def GetAnalysisForClient(crash_identifiers, client_id):
if client_id == CrashClient.FRACAS:
analysis = FracasCrashAnalysis.Get(crash_identifiers)
elif client_id == CrashClient.CRACAS: # pragma: no cover.
- # TODO(katesonia): Add CracasCrashAnalysis model.
- pass
+ analysis = CracasCrashAnalysis.Get(crash_identifiers)
elif client_id == CrashClient.CLUSTERFUZZ: # pragma: no cover.
# TODO(katesonia): Add ClusterfuzzCrashAnalysis model.
pass
@@ -83,8 +83,7 @@ def ResetAnalysis(analysis, crash_identifiers, chrome_version, signature,
if client_id == CrashClient.FRACAS:
analysis = FracasCrashAnalysis.Create(crash_identifiers)
elif client_id == CrashClient.CRACAS: # pragma: no cover.
- # TODO(katesonia): define CracasCrashAnalysis.
- pass
+ analysis = CracasCrashAnalysis.Create(crash_identifiers)
elif client_id == CrashClient.CLUSTERFUZZ: # pragma: no cover.
# TODO(katesonia): define ClusterfuzzCrashAnalysis.
pass

Powered by Google App Engine
This is Rietveld 408576698