Chromium Code Reviews| Index: appengine/findit/model/crash/chrome_crash_analysis.py |
| diff --git a/appengine/findit/model/crash/fracas_crash_analysis.py b/appengine/findit/model/crash/chrome_crash_analysis.py |
| similarity index 75% |
| copy from appengine/findit/model/crash/fracas_crash_analysis.py |
| copy to appengine/findit/model/crash/chrome_crash_analysis.py |
| index d1214a3fb5e6c8e4a21d79576d2a66a80a41aa5a..c18d4fe40cb02b996ccadffa2266a683e4eb7b88 100644 |
| --- a/appengine/findit/model/crash/fracas_crash_analysis.py |
| +++ b/appengine/findit/model/crash/chrome_crash_analysis.py |
| @@ -10,21 +10,20 @@ from google.appengine.ext import ndb |
| from model.crash.crash_analysis import CrashAnalysis |
| -class FracasCrashAnalysis(CrashAnalysis): |
| - """Represents an analysis of a Chrome crash.""" |
| +class ChromeCrashAnalysis(CrashAnalysis): |
| + """Represents an analysis of a Chrome crash (Cracas and Fracas).""" |
|
wrengr (wrong one)
2016/09/10 00:22:06
nit: Crash should be capitalized
Sharu Jiang
2016/09/14 20:46:36
Done.
|
| # Customized properties for Fracas crash. |
| historical_metadata = ndb.JsonProperty(indexed=False) |
| channel = ndb.StringProperty(indexed=False) |
| def Reset(self): |
| - super(FracasCrashAnalysis, self).Reset() |
| + super(ChromeCrashAnalysis, self).Reset() |
| self.historical_metadata = None |
| self.channel = None |
| @staticmethod |
| def _CreateKey(crash_identifiers): |
| - return ndb.Key('FracasCrashAnalysis', hashlib.sha1( |
| - json.dumps(crash_identifiers, sort_keys=True)).hexdigest()) |
| + raise NotImplementedError() |
| @classmethod |
| def Get(cls, crash_identifiers): |