[Findit] Add cracas_crash_analysis

appengine/findit/model/crash/chrome_crash_analysis.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import hashlib
 import json
 
 from google.appengine.ext import ndb
 
 from model.crash.crash_analysis import CrashAnalysis
 
 
-class FracasCrashAnalysis(CrashAnalysis):
-  """Represents an analysis of a Chrome crash."""
+class ChromeCrashAnalysis(CrashAnalysis):
+  """Represents an analysis of a Chrome crash (Cracas and Fracas)."""

[wrengr (wrong one), 2016/09/10 00:22:06]

nit: Crash should be capitalized

[Sharu Jiang, 2016/09/14 20:46:36]

Done.

   # Customized properties for Fracas crash.
   historical_metadata = ndb.JsonProperty(indexed=False)
   channel = ndb.StringProperty(indexed=False)
 
   def Reset(self):
-    super(FracasCrashAnalysis, self).Reset()
+    super(ChromeCrashAnalysis, self).Reset()
     self.historical_metadata = None
     self.channel = None
 
   @staticmethod
   def _CreateKey(crash_identifiers):
-    return ndb.Key('FracasCrashAnalysis', hashlib.sha1(
-        json.dumps(crash_identifiers, sort_keys=True)).hexdigest())
+    raise NotImplementedError()
 
   @classmethod
   def Get(cls, crash_identifiers):
     return cls._CreateKey(crash_identifiers).get()
 
   @classmethod
   def Create(cls, crash_identifiers):
     analysis = cls(key=cls._CreateKey(crash_identifiers))
     return analysis

[wrengr (wrong one), 2016/09/10 00:22:06]

It's not part of your diff, but while you're at it this method should just
return the analysis directly, rather than stashing it in a variable first.

[Sharu Jiang, 2016/09/14 20:46:36]

Done.