Revert of Add GetAssociatedOutputDeviceID support to pulse.

Revert of Add GetAssociatedOutputDeviceID support to pulse. (patchset #7 id:120001 of https://codereview.chromium.org/2258143002/ )

Reason for revert:
Breaks audio playback on Linux Chrome OS
target_os = "chromeos" in gn args

( SoundsManager::Play fails).

Original issue's description:
> Add GetAssociatedOutputDeviceID support to pulse.
> We use the bus path for identification of devices. I have verified that it works with a headset connected with 3.5 mm connectors, and with a USB headset. Another nice thing with  his approach is that we should be able to easily find if a webcam has a built-in mic, since in this case the webcam and mic will typically be connected via the same USB port.
>
> BUG=636300
>
> Committed: https://crrev.com/cff5a1f78bd76f764a70efcdb9b908ff6a87c60f
> Cr-Commit-Position: refs/heads/master@{#415024}

TBR=guidou@chromium.org,tommi@chromium.org,maxmorin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=636300
Committed: https://crrev.com/fdaa93d6a62212b4bab1eb6709a42e9225c56fe4
Cr-Commit-Position: refs/heads/master@{#417523}

[David Tseng, 2016-09-08 22:23:02]

Created Revert of Add GetAssociatedOutputDeviceID support to pulse.

[David Tseng, 2016-09-08 22:23:21]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2016-09-08 22:24:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 00:14:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 00:14:19]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[David Tseng, 2016-09-09 05:57:31]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2016-09-09 05:57:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 06:45:39]

Description was changed from

==========
Revert of Add GetAssociatedOutputDeviceID support to pulse. (patchset #7
id:120001 of https://codereview.chromium.org/2258143002/ )

Reason for revert:
Breaks audio playback on Linux Chrome OS
target_os = "chromeos" in gn args

( SoundsManager::Play fails).

Original issue's description:
> Add GetAssociatedOutputDeviceID support to pulse.
> We use the bus path for identification of devices. I have verified that it
works with a headset connected with 3.5 mm connectors, and with a USB headset.
Another nice thing with  his approach is that we should be able to easily find
if a webcam has a built-in mic, since in this case the webcam and mic will
typically be connected via the same USB port.
> 
> BUG=636300
> 
> Committed: https://crrev.com/cff5a1f78bd76f764a70efcdb9b908ff6a87c60f
> Cr-Commit-Position: refs/heads/master@{#415024}

TBR=guidou@chromium.org,tommi@chromium.org,maxmorin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=636300
==========

to

==========
Revert of Add GetAssociatedOutputDeviceID support to pulse. (patchset #7
id:120001 of https://codereview.chromium.org/2258143002/ )

Reason for revert:
Breaks audio playback on Linux Chrome OS
target_os = "chromeos" in gn args

( SoundsManager::Play fails).

Original issue's description:
> Add GetAssociatedOutputDeviceID support to pulse.
> We use the bus path for identification of devices. I have verified that it
works with a headset connected with 3.5 mm connectors, and with a USB headset.
Another nice thing with  his approach is that we should be able to easily find
if a webcam has a built-in mic, since in this case the webcam and mic will
typically be connected via the same USB port.
> 
> BUG=636300
> 
> Committed: https://crrev.com/cff5a1f78bd76f764a70efcdb9b908ff6a87c60f
> Cr-Commit-Position: refs/heads/master@{#415024}

TBR=guidou@chromium.org,tommi@chromium.org,maxmorin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=636300
==========

[commit-bot: I haz the power, 2016-09-09 06:45:39]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-09 06:47:13]

Description was changed from

==========
Revert of Add GetAssociatedOutputDeviceID support to pulse. (patchset #7
id:120001 of https://codereview.chromium.org/2258143002/ )

Reason for revert:
Breaks audio playback on Linux Chrome OS
target_os = "chromeos" in gn args

( SoundsManager::Play fails).

Original issue's description:
> Add GetAssociatedOutputDeviceID support to pulse.
> We use the bus path for identification of devices. I have verified that it
works with a headset connected with 3.5 mm connectors, and with a USB headset.
Another nice thing with  his approach is that we should be able to easily find
if a webcam has a built-in mic, since in this case the webcam and mic will
typically be connected via the same USB port.
> 
> BUG=636300
> 
> Committed: https://crrev.com/cff5a1f78bd76f764a70efcdb9b908ff6a87c60f
> Cr-Commit-Position: refs/heads/master@{#415024}

TBR=guidou@chromium.org,tommi@chromium.org,maxmorin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=636300
==========

to

==========
Revert of Add GetAssociatedOutputDeviceID support to pulse. (patchset #7
id:120001 of https://codereview.chromium.org/2258143002/ )

Reason for revert:
Breaks audio playback on Linux Chrome OS
target_os = "chromeos" in gn args

( SoundsManager::Play fails).

Original issue's description:
> Add GetAssociatedOutputDeviceID support to pulse.
> We use the bus path for identification of devices. I have verified that it
works with a headset connected with 3.5 mm connectors, and with a USB headset.
Another nice thing with  his approach is that we should be able to easily find
if a webcam has a built-in mic, since in this case the webcam and mic will
typically be connected via the same USB port.
>
> BUG=636300
>
> Committed: https://crrev.com/cff5a1f78bd76f764a70efcdb9b908ff6a87c60f
> Cr-Commit-Position: refs/heads/master@{#415024}

TBR=guidou@chromium.org,tommi@chromium.org,maxmorin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=636300

Committed: https://crrev.com/fdaa93d6a62212b4bab1eb6709a42e9225c56fe4
Cr-Commit-Position: refs/heads/master@{#417523}
==========

[commit-bot: I haz the power, 2016-09-09 06:47:14]

Patchset 1 (id:??) landed as
https://crrev.com/fdaa93d6a62212b4bab1eb6709a42e9225c56fe4
Cr-Commit-Position: refs/heads/master@{#417523}

[Max Morin, 2016-09-12 08:14:40]

On 2016/09/08 22:23:02, David Tseng wrote:
> Created Revert of Add GetAssociatedOutputDeviceID support to pulse.

Could you give steps to reproduce or an automated test?

Thanks,
Max

[David Tseng, 2016-09-12 17:59:47]

Sure; build target_os = "chromeos" and run. Press ctrl+alt+z.
expected: should hear an audio clip play

Code used to trigger the pcall to SoundsManager::Play is at:
chrome/browser/chromeos/accessibility/accessibility_manager

On Mon, Sep 12, 2016 at 1:14 AM, <maxmorin@chromium.org> wrote:

> On 2016/09/08 22:23:02, David Tseng wrote:
> > Created Revert of Add GetAssociatedOutputDeviceID support to pulse.
>
> Could you give steps to reproduce or an automated test?
>
> Thanks,
> Max
>
> https://codereview.chromium.org/2322083003/
>
> --
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.