Fix memory management errors for font loading and copying

Fix memory management errors for font loading and copying

A few issues are fixed:
--Change variable |m_bLogic| in CFX_Font to |m_bShallowCopy| to
reflect its meaning better;
--For a shallow copy of font, we must guarantee that the copied font
will not be deleted until the shallow copy is deleted. So need to
increase the src font's refcount when copying it;
--The stream |m_pOwnedStream| needs to have matched new/delete

These errors need to be fixed before we can properly delete all the
fonts to address the leaks.

BUG=pdfium:242
Committed: https://pdfium.googlesource.com/pdfium/+/c29fc707b24b9528e41a242cfa298275708ffc76

[Wei Li, 2016-09-08 17:45:31]

Description was changed from

==========
Fix memory management errors for font loading and copying

A few issues are fixed:
--Change variable |m_bLogic| in CFX_Font to |m_bShallowCopy| to
reflect its meaning better;
--For a shadow copy of font, we must guarantee that the copied font
will not be deleted until the shadow copy is deleted. So need to
increase the src font's refcount when copying it;
--The stream |m_pOwnedStream| needs to have matched new/delete

These errors need to be fixed before we can properly delete all the
fonts to address the leaks.

BUG=pdfium:242
==========

to

==========
Fix memory management errors for font loading and copying

A few issues are fixed:
--Change variable |m_bLogic| in CFX_Font to |m_bShallowCopy| to
reflect its meaning better;
--For a shallow copy of font, we must guarantee that the copied font
will not be deleted until the shallow copy is deleted. So need to
increase the src font's refcount when copying it;
--The stream |m_pOwnedStream| needs to have matched new/delete

These errors need to be fixed before we can properly delete all the
fonts to address the leaks.

BUG=pdfium:242
==========

[Wei Li, 2016-09-08 18:04:08]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 18:04:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 18:16:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 18:16:49]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-09-08 18:17:48]

weili@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org

[Wei Li, 2016-09-08 18:17:48]

pls review, thanks

[dsinclair, 2016-09-08 18:27:22]

lgtm w/ nit

https://codereview.chromium.org/2322043002/diff/20001/xfa/fgas/font/fgas_gefo...
File xfa/fgas/font/fgas_gefont.cpp (right):

https://codereview.chromium.org/2322043002/diff/20001/xfa/fgas/font/fgas_gefo...
xfa/fgas/font/fgas_gefont.cpp:99: ASSERT(src->m_pFont);
Can we change the src-> to m_pSrcFont-> in here to be consistent?

[Wei Li, 2016-09-08 18:31:36]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 18:31:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Wei Li, 2016-09-08 18:42:02]

thanks, fixed

https://codereview.chromium.org/2322043002/diff/20001/xfa/fgas/font/fgas_gefo...
File xfa/fgas/font/fgas_gefont.cpp (right):

https://codereview.chromium.org/2322043002/diff/20001/xfa/fgas/font/fgas_gefo...
xfa/fgas/font/fgas_gefont.cpp:99: ASSERT(src->m_pFont);
On 2016/09/08 18:27:22, dsinclair wrote:
> Can we change the src-> to m_pSrcFont-> in here to be consistent?

Done.

[commit-bot: I haz the power, 2016-09-08 18:46:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 18:46:18]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-09-08 18:47:09]

The CQ bit was checked by weili@chromium.org

[Wei Li, 2016-09-08 18:47:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/2322043002/#ps40001
(title: "address comments")

[commit-bot: I haz the power, 2016-09-08 18:47:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 18:47:31]

Description was changed from

==========
Fix memory management errors for font loading and copying

A few issues are fixed:
--Change variable |m_bLogic| in CFX_Font to |m_bShallowCopy| to
reflect its meaning better;
--For a shallow copy of font, we must guarantee that the copied font
will not be deleted until the shallow copy is deleted. So need to
increase the src font's refcount when copying it;
--The stream |m_pOwnedStream| needs to have matched new/delete

These errors need to be fixed before we can properly delete all the
fonts to address the leaks.

BUG=pdfium:242
==========

to

==========
Fix memory management errors for font loading and copying

A few issues are fixed:
--Change variable |m_bLogic| in CFX_Font to |m_bShallowCopy| to
reflect its meaning better;
--For a shallow copy of font, we must guarantee that the copied font
will not be deleted until the shallow copy is deleted. So need to
increase the src font's refcount when copying it;
--The stream |m_pOwnedStream| needs to have matched new/delete

These errors need to be fixed before we can properly delete all the
fonts to address the leaks.

BUG=pdfium:242

Committed:
https://pdfium.googlesource.com/pdfium/+/c29fc707b24b9528e41a242cfa298275708f...
==========

[commit-bot: I haz the power, 2016-09-08 18:47:33]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/c29fc707b24b9528e41a242cfa298275708f...