Issue 23219002: Add double unary operation (negate).

Issue 23219002: Add double unary operation (negate). (Closed)

Created:
7 years, 4 months ago by srdjan

Modified:
7 years, 2 months ago

Reviewers:
zra, regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Patch Set 3 : #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+187 lines, -33 lines)			Patch
M	runtime/vm/flow_graph_optimizer.cc	View		2 chunks	+16 lines, -8 lines	0 comments	Download
M	runtime/vm/flow_graph_type_propagator.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2	4 chunks	+55 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View		1 chunk	+18 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View		1 chunk	+18 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1 2	1 chunk	+27 lines, -0 lines	1 comment	Download
M	runtime/vm/intermediate_language_x64.cc	View		2 chunks	+42 lines, -24 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/23219002/diff/8001/runtime/vm/intermediate_language.h File runtime/vm/intermediate_language.h (right): https://codereview.chromium.org/23219002/diff/8001/runtime/vm/intermediate_language.h#newcode6067 runtime/vm/intermediate_language.h:6067: // Overrided generated deopt_id. Overridden https://codereview.chromium.org/23219002/diff/8001/runtime/vm/intermediate_language_mips.cc File runtime/vm/intermediate_language_mips.cc ...

7 years, 4 months ago (2013-08-14 22:07:46 UTC) #2

srdjan

https://codereview.chromium.org/23219002/diff/8001/runtime/vm/intermediate_language.h File runtime/vm/intermediate_language.h (right): https://codereview.chromium.org/23219002/diff/8001/runtime/vm/intermediate_language.h#newcode6067 runtime/vm/intermediate_language.h:6067: // Overrided generated deopt_id. On 2013/08/14 22:07:47, regis wrote: ...

7 years, 4 months ago (2013-08-14 23:04:30 UTC) #3

zra

https://chromiumcodereview.appspot.com/23219002/diff/19001/runtime/vm/intermediate_language_mips.cc File runtime/vm/intermediate_language_mips.cc (right): https://chromiumcodereview.appspot.com/23219002/diff/19001/runtime/vm/intermediate_language_mips.cc#newcode3233 runtime/vm/intermediate_language_mips.cc:3233: LocationSummary* UnaryDoubleOpInstr::MakeLocationSummary() const { It seems this code was ...

7 years, 4 months ago (2013-08-15 16:07:34 UTC) #5

regis

7 years, 4 months ago (2013-08-15 16:55:55 UTC) #6

On 2013/08/15 16:07:34, zra wrote:
>
https://chromiumcodereview.appspot.com/23219002/diff/19001/runtime/vm/interme...
> File runtime/vm/intermediate_language_mips.cc (right):
> 
>
https://chromiumcodereview.appspot.com/23219002/diff/19001/runtime/vm/interme...
> runtime/vm/intermediate_language_mips.cc:3233: LocationSummary*
> UnaryDoubleOpInstr::MakeLocationSummary() const {
> It seems this code was committed already, but I don't see a commit message in
> the code review. I'm not sure what's going on, but this code is making the
> simmips debug bot red. I will submit a TBR CL to fix.

Srdjan lost this changelist probably due to a bug with gclient and recreated it:
https://codereview.chromium.org/22999011/

Thanks for fixing this issue on MIPS. Looking at it now...

Expand Messages | Collapse Messages