Exclude exe files while unzipping CRXes

extensions/utility/unpacker.cc

Index: extensions/utility/unpacker.cc
diff --git a/extensions/utility/unpacker.cc b/extensions/utility/unpacker.cc
index 4c3dbd48a947979061842f9d4b12cb64d8bae7b2..a895c8cdef717b3ffa1405fba0219eb96cf14eb1 100644
--- a/extensions/utility/unpacker.cc
+++ b/extensions/utility/unpacker.cc
@@ -115,6 +115,11 @@ Unpacker::Unpacker(const base::FilePath& working_dir,
 Unpacker::~Unpacker() {
 }
 
+// static
+bool Unpacker::ShouldExtractFile(const base::FilePath& file_path) {
+  return file_path.FinalExtension() != FILE_PATH_LITERAL(".exe");

[hshi, 2016/09/08 22:54:43]

See filepath.h:

  // Returns true if the file path matches the specified extension. The test is
  // case insensitive. Don't forget the leading period if appropriate.
  bool MatchesExtension(StringPieceType extension) const;

[meacer, 2016/09/09 00:37:14]

Oh, great catch! Done, and I updated the crx with test1.EXE and test2.exe files.

+}
+
 std::unique_ptr<base::DictionaryValue> Unpacker::ReadManifest() {
   base::FilePath manifest_path = extension_dir_.Append(kManifestFilename);
   if (!base::PathExists(manifest_path)) {