Exclude exe files while unzipping CRXes

extensions/utility/unpacker.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/utility/unpacker.h"
 
 #include <stddef.h>
 
 #include <set>
 #include <tuple>
@@ skipping 97 matching lines @@
       extension_dir_(extension_dir),
       extension_id_(extension_id),
       location_(location),
       creation_flags_(creation_flags) {
   internal_data_.reset(new InternalData());
 }
 
 Unpacker::~Unpacker() {
 }
 
+// static
+bool Unpacker::ShouldExtractFile(const base::FilePath& file_path) {
+  return file_path.FinalExtension() != FILE_PATH_LITERAL(".exe");

[hshi, 2016/09/08 22:54:43]

See filepath.h:

  // Returns true if the file path matches the specified extension. The test is
  // case insensitive. Don't forget the leading period if appropriate.
  bool MatchesExtension(StringPieceType extension) const;

[meacer, 2016/09/09 00:37:14]

Oh, great catch! Done, and I updated the crx with test1.EXE and test2.exe files.

+}
+
 std::unique_ptr<base::DictionaryValue> Unpacker::ReadManifest() {
   base::FilePath manifest_path = extension_dir_.Append(kManifestFilename);
   if (!base::PathExists(manifest_path)) {
     SetError(errors::kInvalidManifest);
     return NULL;
   }
 
   JSONFileValueDeserializer deserializer(manifest_path);
   std::string error;
   std::unique_ptr<base::Value> root = deserializer.Deserialize(NULL, &error);
@@ skipping 161 matching lines @@
 
 void Unpacker::SetError(const std::string& error) {
   SetUTF16Error(base::UTF8ToUTF16(error));
 }
 
 void Unpacker::SetUTF16Error(const base::string16& error) {
   error_message_ = error;
 }
 
 }  // namespace extensions