Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1171)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2321803002: Deletes remaining traces of gyp in services/ and mojo/ (Closed)

Created:
4 years, 3 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deletes remaining traces of gyp in services/ and mojo/ BUG=None TBR=ben@chromium.org Committed: https://crrev.com/f76be6c1d00b91c8155710897da9d2e0c5f04a63 Cr-Commit-Position: refs/heads/master@{#417195}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -492 lines) Patch
M mojo/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/common/BUILD.gn View 3 chunks +0 lines, -4 lines 0 comments Download
M mojo/public/c/test_support/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/cpp/test_support/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D mojo/public/tools/bindings/mojom_list_outputs.py View 1 chunk +0 lines, -44 lines 0 comments Download
D mojo/public/tools/prepend.py View 1 chunk +0 lines, -37 lines 0 comments Download
M services/shell/public/cpp/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M services/shell/public/interfaces/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D services/shell/public/service_manifest.gypi View 1 chunk +0 lines, -56 lines 0 comments Download
D services/shell/shell.gyp View 1 chunk +0 lines, -204 lines 0 comments Download
D services/shell/shell_public.gyp View 1 chunk +0 lines, -78 lines 0 comments Download
D services/tracing/tracing.gyp View 1 chunk +0 lines, -62 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321803002/1
4 years, 3 months ago (2016-09-07 23:34:10 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/65395) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 3 months ago (2016-09-07 23:38:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321803002/1
4 years, 3 months ago (2016-09-08 03:48:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 05:42:00 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 05:44:38 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f76be6c1d00b91c8155710897da9d2e0c5f04a63
Cr-Commit-Position: refs/heads/master@{#417195}

Powered by Google App Engine
This is Rietveld 408576698