Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2321763002: Moves some shutdown related code to earlier on in function (Closed)

Created:
4 years, 3 months ago by sky
Modified:
4 years, 3 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves some shutdown related code to earlier on in function I would like to share more shutdown code between cash and mash, moving this code earlier on will make it easier to share. BUG=none TEST=covered by tests R=jamescook@chromium.org Committed: https://crrev.com/29f31715ad035be45c19469afe2012209cb92125 Cr-Commit-Position: refs/heads/master@{#417104}

Patch Set 1 #

Total comments: 2

Patch Set 2 : move to end #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ash/root_window_controller.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
sky
4 years, 3 months ago (2016-09-07 21:25:52 UTC) #3
James Cook
https://codereview.chromium.org/2321763002/diff/1/ash/root_window_controller.cc File ash/root_window_controller.cc (right): https://codereview.chromium.org/2321763002/diff/1/ash/root_window_controller.cc#newcode569 ash/root_window_controller.cc:569: // Close wallpaper widget first as it depends on ...
4 years, 3 months ago (2016-09-07 21:41:45 UTC) #4
sky
https://codereview.chromium.org/2321763002/diff/1/ash/root_window_controller.cc File ash/root_window_controller.cc (right): https://codereview.chromium.org/2321763002/diff/1/ash/root_window_controller.cc#newcode569 ash/root_window_controller.cc:569: // Close wallpaper widget first as it depends on ...
4 years, 3 months ago (2016-09-07 22:02:27 UTC) #8
James Cook
LGTM
4 years, 3 months ago (2016-09-07 22:08:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321763002/20001
4 years, 3 months ago (2016-09-07 22:13:36 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-07 22:50:56 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 22:52:43 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/29f31715ad035be45c19469afe2012209cb92125
Cr-Commit-Position: refs/heads/master@{#417104}

Powered by Google App Engine
This is Rietveld 408576698