[MD settings] move the subpage search underline up

[MD settings] move the subpage search underline up

This CL moves the underline in the subpage search up by two px, to match
mocks (request by Alan).

BUG=638453
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/4b524d105844e575ee4d00d5a342931903786408
Cr-Commit-Position: refs/heads/master@{#417319}

[dschuyler, 2016-09-07 19:27:41]

Description was changed from

==========
[MD settings] move the subpage search underline up

This CL moves the underline in the subpage search up by two px, to match
mocks (request by Alan).

BUG=638453
==========

to

==========
[MD settings] move the subpage search underline up

This CL moves the underline in the subpage search up by two px, to match
mocks (request by Alan).

BUG=638453
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-09-07 19:27:43]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 19:28:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-09-07 19:28:31]

dschuyler@chromium.org changed reviewers:
+ stevenjb@chromium.org

[commit-bot: I haz the power, 2016-09-07 20:36:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 20:36:17]

Dry run: This issue passed the CQ dry run.

[stevenjb, 2016-09-08 16:36:06]

lgtm with or without optional nit

https://codereview.chromium.org/2321733002/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/settings_page/settings_subpage_search.html
(right):

https://codereview.chromium.org/2321733002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page/settings_subpage_search.html:12:
--subpage-search-underline: {
nit: Would it be more clear if we named these something something like
--paper-input-container-underline--search so that it could be in the same :host
block? I don't really have a strong opinion, just a thought.

[dschuyler, 2016-09-08 16:57:44]

https://codereview.chromium.org/2321733002/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/settings_page/settings_subpage_search.html
(right):

https://codereview.chromium.org/2321733002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page/settings_subpage_search.html:12:
--subpage-search-underline: {
On 2016/09/08 16:36:06, stevenjb wrote:
> nit: Would it be more clear if we named these something something like
> --paper-input-container-underline--search so that it could be in the same
:host
> block? I don't really have a strong opinion, just a thought.

I wondered about something similar. My reasoning is that
it's more clear to 'know' that --paper-* refers to polymer
paper elements.

I'm wondering about excluding --foo- vars from the 
alphabetical requirement. I'll start a doc or separate thread
about it.

[dschuyler, 2016-09-08 16:57:50]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2016-09-08 16:58:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 17:05:45]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-08 17:07:46]

Description was changed from

==========
[MD settings] move the subpage search underline up

This CL moves the underline in the subpage search up by two px, to match
mocks (request by Alan).

BUG=638453
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] move the subpage search underline up

This CL moves the underline in the subpage search up by two px, to match
mocks (request by Alan).

BUG=638453
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/4b524d105844e575ee4d00d5a342931903786408
Cr-Commit-Position: refs/heads/master@{#417319}
==========

[commit-bot: I haz the power, 2016-09-08 17:07:47]

Patchset 1 (id:??) landed as
https://crrev.com/4b524d105844e575ee4d00d5a342931903786408
Cr-Commit-Position: refs/heads/master@{#417319}