Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: chrome/browser/resources/settings/settings_page/settings_subpage_search.html

Issue 2321733002: [MD settings] move the subpage search underline up (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/cr_elements/cr_search_field/cr_searc h_field_behavior.html"> 1 <link rel="import" href="chrome://resources/cr_elements/cr_search_field/cr_searc h_field_behavior.html">
2 <link rel="import" href="chrome://resources/cr_elements/icons.html"> 2 <link rel="import" href="chrome://resources/cr_elements/icons.html">
3 <link rel="import" href="chrome://resources/html/polymer.html"> 3 <link rel="import" href="chrome://resources/html/polymer.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input -container.html"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input -container.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html">
7 7
8 <dom-module id="settings-subpage-search"> 8 <dom-module id="settings-subpage-search">
9 <template> 9 <template>
10 <style> 10 <style>
11 :host { 11 :host {
12 --subpage-search-underline: {
stevenjb 2016/09/08 16:36:06 nit: Would it be more clear if we named these some
dschuyler 2016/09/08 16:57:44 I wondered about something similar. My reasoning i
13 margin-bottom: -2px;
14 margin-top: -2px;
15 }
16 }
17
18 :host {
19 --paper-input-container-underline: var(--subpage-search-underline);
20 --paper-input-container-underline-focus:
21 var(--subpage-search-underline);
22 --paper-input-container-underline-disabled:
23 var(--subpage-search-underline);
12 --paper-input-suffix: { 24 --paper-input-suffix: {
13 /* Required to align the icon in |clearSearch| vertically. */ 25 /* Required to align the icon in |clearSearch| vertically. */
14 line-height: 0; 26 line-height: 0;
15 } 27 }
16 } 28 }
17 29
18 paper-icon-button { 30 paper-icon-button {
19 /* A 16px icon that fits on the input line. */ 31 /* A 16px icon that fits on the input line. */
20 height: 24px; 32 height: 24px;
21 padding: 4px; 33 padding: 4px;
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 <input is="iron-input" id="searchInput" type="search" 67 <input is="iron-input" id="searchInput" type="search"
56 aria-labelledby="prompt" incremental> 68 aria-labelledby="prompt" incremental>
57 </input> 69 </input>
58 <paper-icon-button suffix icon="cr:cancel" id="clearSearch" 70 <paper-icon-button suffix icon="cr:cancel" id="clearSearch"
59 on-tap="onTapClear_" title="[[clearLabel]]" hidden$="[[!lastValue_]]"> 71 on-tap="onTapClear_" title="[[clearLabel]]" hidden$="[[!lastValue_]]">
60 </paper-icon-button> 72 </paper-icon-button>
61 </paper-input-container> 73 </paper-input-container>
62 </template> 74 </template>
63 <script src="settings_subpage_search.js"></script> 75 <script src="settings_subpage_search.js"></script>
64 </dom-module> 76 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698