Add shader-based GaussianEdgeShader for reveal case

Add shader-based GaussianEdgeShader for reveal case

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2321713004

Committed: https://skia.googlesource.com/skia/+/2af83ac4f6c1b162e17ee70bc97c0553606d7f24

[robertphillips, 2016-09-09 13:52:31]

Description was changed from

==========
Add shader-based GaussianEdgeShader for reveal case
==========

to

==========
Add shader-based GaussianEdgeShader for reveal case
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2321713004
==========

[robertphillips, 2016-09-12 12:46:27]

Description was changed from

==========
Add shader-based GaussianEdgeShader for reveal case
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2321713004
==========

to

==========
Add shader-based GaussianEdgeShader for reveal case

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2321713004
==========

[robertphillips, 2016-09-12 12:46:27]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com, jvanverth@google.com

[robertphillips, 2016-09-12 12:47:32]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 12:47:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 12:49:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 12:49:53]

Dry run: Try jobs failed on following builders:
  Build-Mac-Clang-x86_64-Release-GN-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)

[robertphillips, 2016-09-12 13:51:47]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 13:51:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 14:20:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 14:20:47]

Dry run: This issue passed the CQ dry run.

[bsalomon, 2016-09-12 14:56:52]

lgtm w/ some questions

https://codereview.chromium.org/2321713004/diff/40001/gm/reveal.cpp
File gm/reveal.cpp (right):

https://codereview.chromium.org/2321713004/diff/40001/gm/reveal.cpp#newcode274
gm/reveal.cpp:274: kBlurMask_Mode,
Are the other modes just for debugging? Would it make sense to run all three?

https://codereview.chromium.org/2321713004/diff/40001/include/effects/SkRRect...
File include/effects/SkRRectsGaussianEdgeShader.h (right):

https://codereview.chromium.org/2321713004/diff/40001/include/effects/SkRRect...
include/effects/SkRRectsGaussianEdgeShader.h:24: *  of the bounding boxes of the
two round rects. Ambitious users can omit the center
Is there a bad behavior if drawn larger or does it just draw transparent black
outside those bounds?

https://codereview.chromium.org/2321713004/diff/40001/src/effects/SkRRectsGau...
File src/effects/SkRRectsGaussianEdgeShader.cpp (right):

https://codereview.chromium.org/2321713004/diff/40001/src/effects/SkRRectsGau...
src/effects/SkRRectsGaussianEdgeShader.cpp:247: if (positions[0] !=
fCachedPositions[0] || positions[1] != fCachedPositions[1] ||
Given the use case wonder if this is worth doing.

[robertphillips, 2016-09-12 15:13:50]

https://codereview.chromium.org/2321713004/diff/40001/gm/reveal.cpp
File gm/reveal.cpp (right):

https://codereview.chromium.org/2321713004/diff/40001/gm/reveal.cpp#newcode274
gm/reveal.cpp:274: kBlurMask_Mode,
On 2016/09/12 14:56:52, bsalomon wrote:
> Are the other modes just for debugging? Would it make sense to run all three?

The other two modes are just so I can toggle the rendering in SampleApp.

https://codereview.chromium.org/2321713004/diff/40001/include/effects/SkRRect...
File include/effects/SkRRectsGaussianEdgeShader.h (right):

https://codereview.chromium.org/2321713004/diff/40001/include/effects/SkRRect...
include/effects/SkRRectsGaussianEdgeShader.h:24: *  of the bounding boxes of the
two round rects. Ambitious users can omit the center
On 2016/09/12 14:56:52, bsalomon wrote:
> Is there a bad behavior if drawn larger or does it just draw transparent black
> outside those bounds?

Right now there is bad behavior but I'm currently working on the shaders so they
will soon be drawing transparent black.

https://codereview.chromium.org/2321713004/diff/40001/src/effects/SkRRectsGau...
File src/effects/SkRRectsGaussianEdgeShader.cpp (right):

https://codereview.chromium.org/2321713004/diff/40001/src/effects/SkRRectsGau...
src/effects/SkRRectsGaussianEdgeShader.cpp:247: if (positions[0] !=
fCachedPositions[0] || positions[1] != fCachedPositions[1] ||
On 2016/09/12 14:56:52, bsalomon wrote:
> Given the use case wonder if this is worth doing.

Yeah I was wondering that too. Removed.

[robertphillips, 2016-09-12 15:45:48]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 15:45:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 16:17:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 16:17:42]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-09-12 18:58:27]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2016-09-12 18:58:27]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/2321713004/#ps80001
(title: "Address code review comments")

[commit-bot: I haz the power, 2016-09-12 18:58:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 19:02:18]

Description was changed from

==========
Add shader-based GaussianEdgeShader for reveal case

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2321713004
==========

to

==========
Add shader-based GaussianEdgeShader for reveal case

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2321713004

Committed:
https://skia.googlesource.com/skia/+/2af83ac4f6c1b162e17ee70bc97c0553606d7f24
==========

[commit-bot: I haz the power, 2016-09-12 19:02:19]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/2af83ac4f6c1b162e17ee70bc97c0553606d7f24

[mtklein_C, 2016-09-12 19:50:03]

On 2016/09/12 at 19:02:19, commit-bot wrote:
> Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/2af83ac4f6c1b162e17ee70bc97c0553606d7f24

Any chance this is you?
https://luci-milo.appspot.com/swarming/task/3138b6e4af0cc410/steps/dm/0/stdout