Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2321703002: Remove all gyp[i] files in //chrome (Closed)

Created:
4 years, 3 months ago by brettw
Modified:
4 years, 3 months ago
CC:
chromium-reviews, asanka, dbeam+watch-options_chromium.org, mcasas+watch+vc_chromium.org, viettrungluu+watch_chromium.org, michaelpg+watch-md-settings_chromium.org, yzshen+watch_chromium.org, pennymac+watch_chromium.org, noyau+watch_chromium.org, arv+watch_chromium.org, native-client-reviews_googlegroups.com, miu+watch_chromium.org, tapted, Matt Giuca, aboxhall+watch_chromium.org, grt+watch_chromium.org, abarth-chromium, Patrick Dubroy, je_julie, gab+watch_chromium.org, devtools-reviews_chromium.org, darin (slow to review), chromium-apps-reviews_chromium.org, dbeam+watch-closure_chromium.org, dbeam+watch-ntp_chromium.org, michaelpg+watch-md-ui_chromium.org, alemate+watch_chromium.org, extensions-reviews_chromium.org, qsr+mojo_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, caitkp+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-downloads_chromium.org, michaelpg+watch-options_chromium.org, media-router+watch_chromium.org, tfarina, nektar+watch_chromium.org, Aaron Boodman, dbeam+watch-history_chromium.org, jlklein+watch-closure_chromium.org, dtseng+watch_chromium.org, wfh+watch_chromium.org, dbeam+watch-settings_chromium.org, pedrosimonetti+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, pfeldman, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove all gyp[i] files in //chrome These are now unused TBR=dpranke@chromium.org TBR=mseaborn (chrome/test/data/nacl) CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/74a71a70583a9fb2623a1c4128ae1ea43186bf9b Cr-Commit-Position: refs/heads/master@{#417100}

Patch Set 1 #

Patch Set 2 : Put back compiled resources #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12751 lines) Patch
M .gn View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/app/version_assembly/chrome_exe_manifest_action.gypi View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/app/version_assembly/version_assembly_manifest_action.gypi View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/app_shim/app_shim.gypi View 1 chunk +0 lines, -85 lines 0 comments Download
D chrome/browser/apps/app_shim/browser_app_shim.gypi View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/devtools/devtools_protocol_constants.gyp View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/extensions/api/api_registration.gyp View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/browser/media/router/media_router.gyp View 1 chunk +0 lines, -96 lines 0 comments Download
D chrome/browser/media/router/media_router.gypi View 1 chunk +0 lines, -77 lines 0 comments Download
D chrome/browser/nacl_host/test/mock_nacl_gdb.gyp View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/browser/resources/chromeos/braille_ime/braille_ime.gyp View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/resources/chromeos/chromevox/chromevox.gyp View 1 chunk +0 lines, -249 lines 0 comments Download
D chrome/browser/resources/chromeos/chromevox/common.gypi View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/resources/chromeos/chromevox/compress_js.gypi View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/resources/chromeos/chromevox/copy_js.gypi View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/browser/resources/chromeos/chromevox/generate_deps.gypi View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/browser/resources/chromeos/chromevox/generate_manifest.gypi View 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/browser/safe_browsing/incident_reporting/verifier_test/verifier_unittest.gyp View 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/browser/ui/cocoa/notifications/notification_common.gyp View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/browser/ui/libgtk2ui/libgtk2ui.gyp View 1 chunk +0 lines, -138 lines 0 comments Download
D chrome/chrome.gyp View 1 chunk +0 lines, -736 lines 0 comments Download
D chrome/chrome_android.gypi View 1 chunk +0 lines, -102 lines 0 comments Download
D chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -3345 lines 0 comments Download
D chrome/chrome_browser_ui_views.gyp View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/chrome_debugger.gypi View 1 chunk +0 lines, -131 lines 0 comments Download
D chrome/chrome_dll.gypi View 1 chunk +0 lines, -367 lines 0 comments Download
D chrome/chrome_dll_bundle.gypi View 1 chunk +0 lines, -261 lines 0 comments Download
D chrome/chrome_exe.gypi View 1 chunk +0 lines, -621 lines 0 comments Download
D chrome/chrome_features.gyp View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/chrome_features.gypi View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/chrome_gpu.gypi View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/chrome_grit_action.gypi View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/chrome_installer.gypi View 1 chunk +0 lines, -1189 lines 0 comments Download
D chrome/chrome_installer_static.gypi View 1 chunk +0 lines, -114 lines 0 comments Download
D chrome/chrome_installer_util.gypi View 1 chunk +0 lines, -277 lines 0 comments Download
D chrome/chrome_ios_bundle_resources.gypi View 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/chrome_process_finder.gypi View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/chrome_repack_chrome_100_percent.gypi View 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/chrome_repack_chrome_200_percent.gypi View 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/chrome_repack_chrome_300_percent.gypi View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/chrome_repack_locales.gypi View 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/chrome_repack_resources.gypi View 1 chunk +0 lines, -55 lines 0 comments Download
D chrome/chrome_resources.gyp View 1 chunk +0 lines, -684 lines 0 comments Download
D chrome/chrome_syzygy.gyp View 1 chunk +0 lines, -123 lines 0 comments Download
D chrome/chrome_syzygy.gypi View 1 chunk +0 lines, -79 lines 0 comments Download
D chrome/chrome_test_support.gypi View 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/chrome_watcher/chrome_watcher.gypi View 1 chunk +0 lines, -134 lines 0 comments Download
D chrome/chrome_web_ui_mojo_bindings.gyp View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/common/extensions/api/api.gyp View 1 chunk +0 lines, -108 lines 0 comments Download
D chrome/common/variations/fieldtrial_testing_config.gyp View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/common_constants.gyp View 1 chunk +0 lines, -145 lines 0 comments Download
D chrome/installer/installer_tools.gyp View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/installer/mac/third_party/bsdiff/goobsdiff.gyp View 1 chunk +0 lines, -63 lines 0 comments Download
D chrome/installer/mac/third_party/xz/xz.gyp View 1 chunk +0 lines, -415 lines 0 comments Download
D chrome/installer/mini_installer.gyp View 1 chunk +0 lines, -90 lines 0 comments Download
D chrome/installer/mini_installer.gypi View 1 chunk +0 lines, -255 lines 0 comments Download
D chrome/installer/mini_installer_syzygy.gyp View 1 chunk +0 lines, -62 lines 0 comments Download
D chrome/installer/mini_installer_version.gyp View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/installer/upgrade_test.gyp View 1 chunk +0 lines, -96 lines 0 comments Download
D chrome/js_unittest_rules.gypi View 1 chunk +0 lines, -89 lines 0 comments Download
D chrome/js_unittest_vars.gypi View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/policy.gypi View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/policy_templates.gypi View 1 chunk +0 lines, -92 lines 0 comments Download
D chrome/test/data/nacl/nacl_test_data.gyp View 1 chunk +0 lines, -1028 lines 0 comments Download
D chrome/test/media_router/e2e_tests.gyp View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/test/media_router/media_router_tests.gypi View 1 chunk +0 lines, -62 lines 0 comments Download
D chrome/test/mini_installer/test_installer.gypi View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/third_party/chromevox/chromevox.gyp View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/tools/convert_dict/convert_dict.gyp View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/version_resource_rules.gypi View 1 chunk +0 lines, -70 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 23 (18 generated)
brettw
merge
4 years, 3 months ago (2016-09-07 20:58:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321703002/40001
4 years, 3 months ago (2016-09-07 22:27:41 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-07 22:36:28 UTC) #20
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/74a71a70583a9fb2623a1c4128ae1ea43186bf9b Cr-Commit-Position: refs/heads/master@{#417100}
4 years, 3 months ago (2016-09-07 22:38:36 UTC) #22
Dirk Pranke
4 years, 3 months ago (2016-09-08 22:06:49 UTC) #23
Message was sent while issue was closed.
rs- lgtm.

Powered by Google App Engine
This is Rietveld 408576698