Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2316293002: Inline extensions API gyp into GN build. (Closed)

Created:
4 years, 3 months ago by brettw
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Inline extensions API gyp into GN build. Delete the associated GYP files. TBR=dpranke@chromium.org Committed: https://crrev.com/3548bcfd9af059820e12ded33fd9fb929783060d Cr-Commit-Position: refs/heads/master@{#417072}

Patch Set 1 #

Patch Set 2 : input private #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -290 lines) Patch
M chrome/common/extensions/api/BUILD.gn View 1 4 chunks +189 lines, -3 lines 0 comments Download
D chrome/common/extensions/api/schemas.gni View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/common/extensions/api/schemas.gypi View 1 chunk +0 lines, -239 lines 0 comments Download

Dependent Patchsets:

Issue 2321703002 Patch 40001

Messages

Total messages: 16 (6 generated)
brettw
4 years, 3 months ago (2016-09-07 18:13:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316293002/1
4 years, 3 months ago (2016-09-07 18:14:40 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/275841)
4 years, 3 months ago (2016-09-07 19:19:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316293002/1
4 years, 3 months ago (2016-09-07 19:41:14 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/293635)
4 years, 3 months ago (2016-09-07 20:39:08 UTC) #9
brettw
input private
4 years, 3 months ago (2016-09-07 20:57:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316293002/20001
4 years, 3 months ago (2016-09-07 20:58:12 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-07 22:04:26 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/3548bcfd9af059820e12ded33fd9fb929783060d Cr-Commit-Position: refs/heads/master@{#417072}
4 years, 3 months ago (2016-09-07 22:07:41 UTC) #15
Dirk Pranke
4 years, 3 months ago (2016-09-08 22:02:51 UTC) #16
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698