Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2321683003: In base::JSONParser, check IsValidCharacter before decoding ASCII/UTF-8. (Closed)

Created:
4 years, 3 months ago by Robert Sesek
Modified:
4 years, 3 months ago
Reviewers:
dcheng
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

In base::JSONParser, check IsValidCharacter before decoding ASCII/UTF-8. BUG=644664 R=dcheng@chromium.org Committed: https://crrev.com/617caed52b42647f938ea49ad9afed9256078198 Cr-Commit-Position: refs/heads/master@{#417121}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M base/json/json_parser.cc View 1 chunk +2 lines, -1 line 0 comments Download
M base/json/json_parser_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Robert Sesek
4 years, 3 months ago (2016-09-07 22:45:22 UTC) #3
dcheng
lgtm
4 years, 3 months ago (2016-09-07 22:52:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321683003/1
4 years, 3 months ago (2016-09-07 22:54:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 23:55:11 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 23:56:53 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/617caed52b42647f938ea49ad9afed9256078198
Cr-Commit-Position: refs/heads/master@{#417121}

Powered by Google App Engine
This is Rietveld 408576698