base/json/json_parser.cc - Issue 2321683003: In base::JSONParser, check IsValidCharacter before decoding ASCII/UTF-8.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/json/json_parser.cc

Issue 2321683003: In base::JSONParser, check IsValidCharacter before decoding ASCII/UTF-8. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/json/json_parser.cc

diff --git a/base/json/json_parser.cc b/base/json/json_parser.cc

index 36e9dcac736938c2e568fbe00c66dea8803f80b0..cf42bfce7229281e28df39521f7bd7cffffe41ec 100644

--- a/base/json/json_parser.cc

+++ b/base/json/json_parser.cc

@@ -670,7 +670,8 @@ bool JSONParser::ConsumeStringRaw(StringBuilder* out) {

}

int hex_digit = 0;

- if (!HexStringToInt(StringPiece(NextChar(), 2), &hex_digit)) {

+ if (!HexStringToInt(StringPiece(NextChar(), 2), &hex_digit) ||

+ !IsValidCharacter(hex_digit)) {

ReportError(JSONReader::JSON_INVALID_ESCAPE, -1);

return false;

}

« no previous file with comments | « no previous file | base/json/json_parser_unittest.cc » ('j') | no next file with comments »