Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2321653002: Add Signin_Impression_FromSettings user action (Closed)

Created:
4 years, 3 months ago by gogerald1
Modified:
4 years, 3 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Signin_Impression_FromSettings user action BUG=639860 Committed: https://crrev.com/8dafb06dc59a8b0ca7c42c79f4177a146e6ef30b Cr-Commit-Position: refs/heads/master@{#417303}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/SignInPreference.java View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
gogerald1
Hi, PTAL,
4 years, 3 months ago (2016-09-07 17:12:49 UTC) #4
Bernhard Bauer
lgtm
4 years, 3 months ago (2016-09-08 09:10:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321653002/1
4 years, 3 months ago (2016-09-08 15:58:45 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 16:06:39 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 16:11:06 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8dafb06dc59a8b0ca7c42c79f4177a146e6ef30b
Cr-Commit-Position: refs/heads/master@{#417303}

Powered by Google App Engine
This is Rietveld 408576698