Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4620)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/SignInPreference.java

Issue 2321653002: Add Signin_Impression_FromSettings user action (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/SignInPreference.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/SignInPreference.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/SignInPreference.java
index ec83e8f23df847a3c1f63537cb0e8cec0da01e12..e4f4cc0437ad0db37f0d165bd45178ffcdfc6354 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/SignInPreference.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/SignInPreference.java
@@ -14,6 +14,7 @@ import android.text.TextUtils;
import android.util.AttributeSet;
import android.view.View;
+import org.chromium.base.metrics.RecordUserAction;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.firstrun.FirstRunSignInProcessor;
import org.chromium.chrome.browser.profiles.Profile;
@@ -141,6 +142,10 @@ public class SignInPreference extends Preference
return true;
}
});
+
+ if (account == null && enabled) {
+ RecordUserAction.record("Signin_Impression_FromSettings");
+ }
}
private void updateSyncStatusIcon() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698