Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 2321603003: Ignore key events in renaming inputs when the keyCode is VK_PROCESSKEY(229). (Closed)

Created:
4 years, 3 months ago by fukino
Modified:
4 years, 3 months ago
Reviewers:
Seigo Nonaka
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Ignore key events in renaming inputs when the keyCode is VK_PROCESSKEY(229). When the key events are consumed by IME, the keyCode in KeyboardEvent.keyCode is VK_PROCESSKEY, but KeyboardEvent.key can be the original key, like 'Enter'. As a workaround, we look into keyCode to ignore the consumed key events not to commit unwanted changes in rename inputs, although the keyCode is deprecated. BUG=644071 TEST=manually tested using the repro steps described in the bug. TBR=nona@chromium.org Review-Url: https://codereview.chromium.org/2309983003 Cr-Commit-Position: refs/heads/master@{#416887} (cherry picked from commit bb7c1663e15a122a64f94f5fac7ca8fdbdf7ec06) Committed: https://chromium.googlesource.com/chromium/src/+/5b94799717dd554ff75a9dac122753bfd5f3ed65

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M ui/file_manager/file_manager/foreground/js/directory_tree_naming_controller.js View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/naming_controller.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
fukino
4 years, 3 months ago (2016-09-08 08:55:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5b94799717dd554ff75a9dac122753bfd5f3ed65 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698