Ignore key events in renaming inputs when the keyCode is VK_PROCESSKEY(229).

Ignore key events in renaming inputs when the keyCode is VK_PROCESSKEY(229).

When the key events are consumed by IME, the keyCode in KeyboardEvent.keyCode is
VK_PROCESSKEY, but KeyboardEvent.key can be the original key, like 'Enter'.
As a workaround, we look into keyCode to ignore the consumed key events not to
commit unwanted changes in rename inputs, although the keyCode is deprecated.

BUG=644071
TEST=manually tested using the repro steps described in the bug.

Committed: https://crrev.com/bb7c1663e15a122a64f94f5fac7ca8fdbdf7ec06
Cr-Commit-Position: refs/heads/master@{#416887}

[fukino, 2016-09-06 12:06:56]

fukino@chromium.org changed reviewers:
+ nona@chromium.org

[fukino, 2016-09-06 12:06:56]

nona@, could you take a look? Thanks!

[Seigo Nonaka, 2016-09-07 08:28:32]

lgtm with a minor nit.


/the keyCode is KeyboardEvent.keyCode/the keyCode in KeyboardEvent.keyCode/
maybe?

[fukino, 2016-09-07 08:34:01]

Description was changed from

==========
Ignore key events in renaming inputs when the keyCode is VK_PROCESSKEY(229).

When the key events are consumed by IME, the keyCode is KeyboardEvent.keyCode is
VK_PROCESSKEY, but KeyboardEvent.key can be the original key, like 'Enter'.
As a workaround, we look into keyCode to ignore the consumed key events not to
commit unwanted changes in rename inputs, although the keyCode is deprecated.

BUG=644071
TEST=manually tested using the repro steps described in the bug.
==========

to

==========
Ignore key events in renaming inputs when the keyCode is VK_PROCESSKEY(229).

When the key events are consumed by IME, the keyCode in KeyboardEvent.keyCode is
VK_PROCESSKEY, but KeyboardEvent.key can be the original key, like 'Enter'.
As a workaround, we look into keyCode to ignore the consumed key events not to
commit unwanted changes in rename inputs, although the keyCode is deprecated.

BUG=644071
TEST=manually tested using the repro steps described in the bug.
==========

[fukino, 2016-09-07 08:34:46]

Updated the description. Thanks!

[fukino, 2016-09-07 08:34:52]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2016-09-07 08:35:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 09:23:06]

Description was changed from

==========
Ignore key events in renaming inputs when the keyCode is VK_PROCESSKEY(229).

When the key events are consumed by IME, the keyCode in KeyboardEvent.keyCode is
VK_PROCESSKEY, but KeyboardEvent.key can be the original key, like 'Enter'.
As a workaround, we look into keyCode to ignore the consumed key events not to
commit unwanted changes in rename inputs, although the keyCode is deprecated.

BUG=644071
TEST=manually tested using the repro steps described in the bug.
==========

to

==========
Ignore key events in renaming inputs when the keyCode is VK_PROCESSKEY(229).

When the key events are consumed by IME, the keyCode in KeyboardEvent.keyCode is
VK_PROCESSKEY, but KeyboardEvent.key can be the original key, like 'Enter'.
As a workaround, we look into keyCode to ignore the consumed key events not to
commit unwanted changes in rename inputs, although the keyCode is deprecated.

BUG=644071
TEST=manually tested using the repro steps described in the bug.
==========

[commit-bot: I haz the power, 2016-09-07 09:23:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-07 09:26:35]

Description was changed from

==========
Ignore key events in renaming inputs when the keyCode is VK_PROCESSKEY(229).

When the key events are consumed by IME, the keyCode in KeyboardEvent.keyCode is
VK_PROCESSKEY, but KeyboardEvent.key can be the original key, like 'Enter'.
As a workaround, we look into keyCode to ignore the consumed key events not to
commit unwanted changes in rename inputs, although the keyCode is deprecated.

BUG=644071
TEST=manually tested using the repro steps described in the bug.
==========

to

==========
Ignore key events in renaming inputs when the keyCode is VK_PROCESSKEY(229).

When the key events are consumed by IME, the keyCode in KeyboardEvent.keyCode is
VK_PROCESSKEY, but KeyboardEvent.key can be the original key, like 'Enter'.
As a workaround, we look into keyCode to ignore the consumed key events not to
commit unwanted changes in rename inputs, although the keyCode is deprecated.

BUG=644071
TEST=manually tested using the repro steps described in the bug.

Committed: https://crrev.com/bb7c1663e15a122a64f94f5fac7ca8fdbdf7ec06
Cr-Commit-Position: refs/heads/master@{#416887}
==========

[commit-bot: I haz the power, 2016-09-07 09:26:36]

Patchset 1 (id:??) landed as
https://crrev.com/bb7c1663e15a122a64f94f5fac7ca8fdbdf7ec06
Cr-Commit-Position: refs/heads/master@{#416887}