Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2321293002: Revert of Use the URL passed to navigator.share(). (Closed)

Created:
4 years, 3 months ago by jam
Modified:
4 years, 3 months ago
CC:
Aaron Boodman, abarth-chromium, blink-reviews, blink-reviews-api_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-reviews, darin (slow to review), dglazkov+blink, haraken, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use the URL passed to navigator.share(). (patchset #2 id:40001 of https://codereview.chromium.org/2309403002/ ) Reason for revert: build failures https://build.chromium.org/p/chromium.linux/builders/Blimp%20Linux%20%28dbg%29/builds/9772/steps/compile/logs/stdio Looks like because of https://codereview.chromium.org/2250613002 which landed after these try runs Original issue's description: > Use the URL passed to navigator.share(). > > BUG=644034 > > Committed: https://crrev.com/746afbd5808e9daa0333e66a7608e0d98283a9c8 > Cr-Commit-Position: refs/heads/master@{#417452} TBR=esprehn@chromium.org,dcheng@chromium.org,dtrainor@chromium.org,mgiuca@chromium.org,sammc@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=644034

Patch Set 1 #

Messages

Total messages: 5 (2 generated)
jam
Created Revert of Use the URL passed to navigator.share().
4 years, 3 months ago (2016-09-09 00:48:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321293002/1
4 years, 3 months ago (2016-09-09 00:49:27 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 00:57:12 UTC) #5
Failed to apply patch for chrome/android/BUILD.gn:
While running git apply --index -3 -p1;
  error: patch failed: chrome/android/BUILD.gn:211
  error: repository lacks the necessary blob to fall back on 3-way merge.
  error: chrome/android/BUILD.gn: patch does not apply

Patch:       chrome/android/BUILD.gn
Index: chrome/android/BUILD.gn
diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn
index
27caf43a18caa2f2433bb9ca84381c8a856d0707..9c37ab871d50a833c23fbadb8a42137fa640c741
100644
--- a/chrome/android/BUILD.gn
+++ b/chrome/android/BUILD.gn
@@ -211,7 +211,6 @@
     "//third_party/jsr-305:jsr_305_javalib",
     "//third_party/leakcanary:leakcanary_java",
     "//ui/android:ui_java",
-    "//url/mojo:url_mojom_gurl_java",
     google_play_services_library,
   ]

Powered by Google App Engine
This is Rietveld 408576698