Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2321263003: Remove parseUriWithException() and URISyntaxException. (Closed)

Created:
4 years, 3 months ago by scheglov
Modified:
4 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove parseUriWithException() and URISyntaxException. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/9cf47ce04c5dfeb20a725860b84e0f0429bc5808

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -92 lines) Patch
M pkg/analysis_server/test/completion_test_support.dart View 2 chunks +1 line, -3 lines 1 comment Download
M pkg/analyzer/lib/source/embedder.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/context/source.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/ast.dart View 2 chunks +7 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/member.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/element/type.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/resolver/scope.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/sdk/sdk.dart View 5 chunks +8 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/generated/java_core.dart View 2 chunks +0 lines, -20 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk_io.dart View 4 chunks +6 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source_io.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/element_factory.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 8 chunks +12 lines, -20 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/resolver_test_case.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/source_factory_test.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/analyzer/test/generated/utilities_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/source/source_resource_test.dart View 5 chunks +5 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 3 months ago (2016-09-09 01:09:55 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2321263003/diff/1/pkg/analysis_server/test/completion_test_support.dart File pkg/analysis_server/test/completion_test_support.dart (left): https://codereview.chromium.org/2321263003/diff/1/pkg/analysis_server/test/completion_test_support.dart#oldcode11 pkg/analysis_server/test/completion_test_support.dart:11: import 'package:analyzer/src/generated/java_core.dart'; If there were no references to ...
4 years, 3 months ago (2016-09-09 13:49:35 UTC) #2
scheglov
4 years, 3 months ago (2016-09-09 15:30:08 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
9cf47ce04c5dfeb20a725860b84e0f0429bc5808 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698