Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1657)

Unified Diff: pkg/analyzer/lib/src/generated/sdk_io.dart

Issue 2321263003: Remove parseUriWithException() and URISyntaxException. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/generated/sdk_io.dart
diff --git a/pkg/analyzer/lib/src/generated/sdk_io.dart b/pkg/analyzer/lib/src/generated/sdk_io.dart
index d9dbcbc355b1b538f4f6f28c3d64f99c9ed8e8f5..09609a4cb9381d944abe748c7c2cb28b28524d21 100644
--- a/pkg/analyzer/lib/src/generated/sdk_io.dart
+++ b/pkg/analyzer/lib/src/generated/sdk_io.dart
@@ -14,7 +14,6 @@ import 'package:analyzer/src/dart/scanner/reader.dart';
import 'package:analyzer/src/dart/scanner/scanner.dart';
import 'package:analyzer/src/generated/engine.dart';
import 'package:analyzer/src/generated/error.dart';
-import 'package:analyzer/src/generated/java_core.dart';
import 'package:analyzer/src/generated/java_engine.dart';
import 'package:analyzer/src/generated/java_engine_io.dart';
import 'package:analyzer/src/generated/java_io.dart';
@@ -133,8 +132,8 @@ abstract class AbstractDartSdk implements DartSdk {
return null;
}
try {
- return new FileBasedSource(file, parseUriWithException(path));
- } on URISyntaxException catch (exception, stackTrace) {
+ return new FileBasedSource(file, Uri.parse(path));
+ } on FormatException catch (exception, stackTrace) {
AnalysisEngine.instance.logger.logInformation(
"Failed to create URI: $path",
new CaughtException(exception, stackTrace));
@@ -189,8 +188,8 @@ abstract class AbstractDartSdk implements DartSdk {
String filePath = srcPath.replaceAll('/', JavaFile.separator);
try {
JavaFile file = new JavaFile(filePath);
- return new FileBasedSource(file, parseUriWithException(dartUri));
- } on URISyntaxException {
+ return new FileBasedSource(file, Uri.parse(dartUri));
+ } on FormatException {
return null;
}
}
@@ -721,8 +720,8 @@ class DirectoryBasedDartSdk extends AbstractDartSdk {
file = file.getParentFile();
file = new JavaFile.relative(file, relativePath);
}
- return new FileBasedSource(file, parseUriWithException(dartUri));
- } on URISyntaxException {
+ return new FileBasedSource(file, Uri.parse(dartUri));
+ } on FormatException {
return null;
}
}

Powered by Google App Engine
This is Rietveld 408576698