Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2144)

Side by Side Diff: components/autofill/content/renderer/password_autofill_agent.cc

Issue 2320993002: [Autofill] Close mojo interface bindings of autofill/password agent in time. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/autofill/content/renderer/password_autofill_agent.h" 5 #include "components/autofill/content/renderer/password_autofill_agent.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <memory> 9 #include <memory>
10 #include <string> 10 #include <string>
(...skipping 1132 matching lines...) Expand 10 before | Expand all | Expand 10 after
1143 // RenderView to be instantiated (such as redirects to the WebStore) 1143 // RenderView to be instantiated (such as redirects to the WebStore)
1144 // we will never get to finish the load. 1144 // we will never get to finish the load.
1145 GetPasswordManagerDriver()->PasswordFormSubmitted(*submitted_form); 1145 GetPasswordManagerDriver()->PasswordFormSubmitted(*submitted_form);
1146 provisionally_saved_form_.reset(); 1146 provisionally_saved_form_.reset();
1147 } else if (logger) { 1147 } else if (logger) {
1148 logger->LogMessage(Logger::STRING_FORM_IS_NOT_PASSWORD); 1148 logger->LogMessage(Logger::STRING_FORM_IS_NOT_PASSWORD);
1149 } 1149 }
1150 } 1150 }
1151 1151
1152 void PasswordAutofillAgent::OnDestruct() { 1152 void PasswordAutofillAgent::OnDestruct() {
1153 binding_.Close();
1153 base::ThreadTaskRunnerHandle::Get()->DeleteSoon(FROM_HERE, this); 1154 base::ThreadTaskRunnerHandle::Get()->DeleteSoon(FROM_HERE, this);
1154 } 1155 }
1155 1156
1156 void PasswordAutofillAgent::DidStartProvisionalLoad() { 1157 void PasswordAutofillAgent::DidStartProvisionalLoad() {
1157 std::unique_ptr<RendererSavePasswordProgressLogger> logger; 1158 std::unique_ptr<RendererSavePasswordProgressLogger> logger;
1158 if (logging_state_active_) { 1159 if (logging_state_active_) {
1159 logger.reset(new RendererSavePasswordProgressLogger( 1160 logger.reset(new RendererSavePasswordProgressLogger(
1160 GetPasswordManagerDriver().get())); 1161 GetPasswordManagerDriver().get()));
1161 logger->LogMessage(Logger::STRING_DID_START_PROVISIONAL_LOAD_METHOD); 1162 logger->LogMessage(Logger::STRING_DID_START_PROVISIONAL_LOAD_METHOD);
1162 } 1163 }
(...skipping 339 matching lines...) Expand 10 before | Expand all | Expand 10 after
1502 PasswordAutofillAgent::GetPasswordManagerDriver() { 1503 PasswordAutofillAgent::GetPasswordManagerDriver() {
1503 if (!password_manager_driver_) { 1504 if (!password_manager_driver_) {
1504 render_frame()->GetRemoteInterfaces()->GetInterface( 1505 render_frame()->GetRemoteInterfaces()->GetInterface(
1505 mojo::GetProxy(&password_manager_driver_)); 1506 mojo::GetProxy(&password_manager_driver_));
1506 } 1507 }
1507 1508
1508 return password_manager_driver_; 1509 return password_manager_driver_;
1509 } 1510 }
1510 1511
1511 } // namespace autofill 1512 } // namespace autofill
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698