Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 2320963002: arc: Support more orientation lock types. (Closed)

Created:
4 years, 3 months ago by Shuhei Takahashi
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

arc: Support more orientation lock types. Four orientation lock types are added for specific rotation angles (0, 90, 180, 270 degrees). Also, Orientation::CURRENT is improved to really lock to the current orientation, not allowing upside-down orientation. BUG=chromium:643102 TEST=Manually tested with a small Android app which calls Activity.setRequestedOrientation(). Review-Url: https://codereview.chromium.org/2300943002 Cr-Commit-Position: refs/heads/master@{#416164} (cherry picked from commit d01b59e76b012baac3a45caf0adf744950cc2ce7) Committed: https://chromium.googlesource.com/chromium/src/+/2e451fa899aa2cdee0243da30c60f89642f714d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -9 lines) Patch
M chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc View 2 chunks +20 lines, -9 lines 0 comments Download
M components/arc/common/app.mojom View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Shuhei Takahashi
4 years, 3 months ago (2016-09-08 07:19:46 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2e451fa899aa2cdee0243da30c60f89642f714d6.

Powered by Google App Engine
This is Rietveld 408576698