Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2300943002: arc: Support more orientation lock types. (Closed)

Created:
4 years, 3 months ago by Shuhei Takahashi
Modified:
4 years, 3 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, kalyank, lhchavez+watch_chromium.org, qsr+mojo_chromium.org, sadrul, viettrungluu+watch_chromium.org, yusukes+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Support more orientation lock types. Four orientation lock types are added for specific rotation angles (0, 90, 180, 270 degrees). Also, Orientation::CURRENT is improved to really lock to the current orientation, not allowing upside-down orientation. BUG=chromium:643102 TEST=Manually tested with a small Android app which calls Activity.setRequestedOrientation(). Committed: https://crrev.com/d01b59e76b012baac3a45caf0adf744950cc2ce7 Cr-Commit-Position: refs/heads/master@{#416164}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -9 lines) Patch
M chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc View 2 chunks +20 lines, -9 lines 0 comments Download
M components/arc/common/app.mojom View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Shuhei Takahashi
oshima: PTAL arc_app_window_launcher_controller.cc hidehiko: PTAL app.mojom rickyz: PTAL app.mojom for security review I know you ...
4 years, 3 months ago (2016-09-01 08:29:46 UTC) #2
hidehiko
LGTM. Defer to other reviewers.
4 years, 3 months ago (2016-09-01 17:11:44 UTC) #3
rickyz (no longer on Chrome)
mojom lgtm
4 years, 3 months ago (2016-09-01 19:29:33 UTC) #4
oshima
lgtm
4 years, 3 months ago (2016-09-02 00:34:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300943002/1
4 years, 3 months ago (2016-09-02 02:05:05 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 02:09:13 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 02:10:34 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d01b59e76b012baac3a45caf0adf744950cc2ce7
Cr-Commit-Position: refs/heads/master@{#416164}

Powered by Google App Engine
This is Rietveld 408576698