blimp/client/core/contents/blimp_navigation_controller_impl.cc - Issue 2320923002: Add a full Blimp integration test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/contents/blimp_navigation_controller_impl.cc

Issue 2320923002: Add a full Blimp integration test. (Closed)

Patch Set: Addressed more comments, added thread restriction bypass for tests. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/client/core/contents/blimp_navigation_controller_impl.cc

diff --git a/blimp/client/core/contents/blimp_navigation_controller_impl.cc b/blimp/client/core/contents/blimp_navigation_controller_impl.cc

index 7461e5db833b73c9d907507e30cf0f520928acc0..f55d0463ff399553a39a42efcecca05c4b31ba58 100644

--- a/blimp/client/core/contents/blimp_navigation_controller_impl.cc

+++ b/blimp/client/core/contents/blimp_navigation_controller_impl.cc

@@ -84,6 +84,7 @@ void BlimpNavigationControllerImpl::OnLoadingChanged(int tab_id, bool loading) {

void BlimpNavigationControllerImpl::OnPageLoadStatusUpdate(int tab_id,

bool completed) {

delegate_->OnNavigationStateChanged();

+ delegate_->OnPageLoadingStateChanged(!completed);

}

} // namespace client