Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: blimp/client/core/contents/blimp_navigation_controller_impl.cc

Issue 2320923002: Add a full Blimp integration test. (Closed)
Patch Set: Addressed more comments, added thread restriction bypass for tests. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "blimp/client/core/contents/blimp_navigation_controller_impl.h" 5 #include "blimp/client/core/contents/blimp_navigation_controller_impl.h"
6 6
7 #include "blimp/client/core/contents/blimp_navigation_controller_delegate.h" 7 #include "blimp/client/core/contents/blimp_navigation_controller_delegate.h"
8 8
9 namespace { 9 namespace {
10 // TODO(shaktisahu): NavigationFeature currently needs a tab_id. Remove this 10 // TODO(shaktisahu): NavigationFeature currently needs a tab_id. Remove this
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 } 77 }
78 78
79 void BlimpNavigationControllerImpl::OnLoadingChanged(int tab_id, bool loading) { 79 void BlimpNavigationControllerImpl::OnLoadingChanged(int tab_id, bool loading) {
80 delegate_->OnNavigationStateChanged(); 80 delegate_->OnNavigationStateChanged();
81 delegate_->OnLoadingStateChanged(loading); 81 delegate_->OnLoadingStateChanged(loading);
82 } 82 }
83 83
84 void BlimpNavigationControllerImpl::OnPageLoadStatusUpdate(int tab_id, 84 void BlimpNavigationControllerImpl::OnPageLoadStatusUpdate(int tab_id,
85 bool completed) { 85 bool completed) {
86 delegate_->OnNavigationStateChanged(); 86 delegate_->OnNavigationStateChanged();
87 delegate_->OnPageLoadingStateChanged(!completed);
87 } 88 }
88 89
89 } // namespace client 90 } // namespace client
90 } // namespace blimp 91 } // namespace blimp
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698