Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: tools/run-bisect-perf-regression.py

Issue 232083003: [bisect] - Add --path_to_config parameter to run script. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/run-bisect-perf-regression.py
diff --git a/tools/run-bisect-perf-regression.py b/tools/run-bisect-perf-regression.py
index 8dceea82fc0bcb8a7a8659aac3c300139e780a15..5d8341f576463a52674528eca27664b97e149a46 100755
--- a/tools/run-bisect-perf-regression.py
+++ b/tools/run-bisect-perf-regression.py
@@ -369,6 +369,11 @@ def main():
type='str',
help='Path to goma directory. If this is supplied, goma '
'builds will be enabled.')
+ parser.add_option('--path_to_config',
+ type='str',
+ help='Path to the config file to use. If this is supplied, '
+ 'the bisect script will use this to override the default '
+ 'config file path.')
parser.add_option('--extra_src',
type='str',
help='Path to extra source file. If this is supplied, '
@@ -381,8 +386,13 @@ def main():
(opts, args) = parser.parse_args()
path_to_current_directory = os.path.abspath(os.path.dirname(sys.argv[0]))
- path_to_bisect_cfg = os.path.join(path_to_current_directory,
- 'run-bisect-perf-regression.cfg')
+
+ # If they've specified their own config file, use that instead.
+ if opts.path_to_config:
+ path_to_bisect_cfg = opts.path_to_config
prasadv 2014/04/09 23:17:51 Should'n we validate whether the path_to_config is
shatch 2014/04/10 17:32:54 Done.
+ else:
+ path_to_bisect_cfg = os.path.join(path_to_current_directory,
+ 'run-bisect-perf-regression.cfg')
config = _LoadConfigFile(path_to_bisect_cfg)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698